Skip to content

Commit 7e28007

Browse files
roypatbchalios
authored andcommitted
test: Remove test_snapshot_compatibility
This test serves no purpose, as all it does is take a snapshot without verifying anything about it. In this sense, it is perfectly subsumed by `test_balloon_snapshot`, which also creates snapshots with balloon devices, but actually verifies they restore as well (something that is not given in this test, because we do not wait for the guest to boot before taking a snapshot). A look at the commit history shows that this test used to be responsible for verifying cross-release snapshot support for the balloon device, but since we no longer support such a thing, it became superfluous. Signed-off-by: Patrick Roy <[email protected]>
1 parent 2e57447 commit 7e28007

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

tests/integration_tests/functional/test_balloon.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -518,24 +518,6 @@ def test_balloon_snapshot(microvm_factory, guest_kernel, rootfs):
518518
assert stats_after_snap["available_memory"] > latest_stats["available_memory"]
519519

520520

521-
def test_snapshot_compatibility(microvm_factory, guest_kernel, rootfs):
522-
"""
523-
Test that the balloon serializes correctly.
524-
"""
525-
vm = microvm_factory.build(guest_kernel, rootfs)
526-
vm.spawn()
527-
vm.basic_config(
528-
vcpu_count=2,
529-
mem_size_mib=256,
530-
)
531-
532-
# Add a memory balloon with stats enabled.
533-
vm.api.balloon.put(amount_mib=0, deflate_on_oom=True, stats_polling_interval_s=1)
534-
535-
vm.start()
536-
vm.snapshot_full()
537-
538-
539521
def test_memory_scrub(microvm_factory, guest_kernel, rootfs):
540522
"""
541523
Test that the memory is zeroed after deflate.

0 commit comments

Comments
 (0)