fix: remove unneeded lint attributes

- Remove `warn` attributes if they are subsumed by `warn` attributes in
  a parent module (this happened a lot with `missing_docs` after we
  turned crates into submodules of `vmm`)
- Remove `allow` attributes for lints we either do not warn on anyway,
  or where they would be duplicated.

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

src/firecracker/src/gen/prctl.rs

@@ -10,7 +10,6 @@
     non_snake_case,
     clippy::ptr_as_ptr,
     clippy::undocumented_unsafe_blocks,
-    clippy::cast_lossless,
     missing_debug_implementations,
     clippy::tests_outside_test_module
 )]

src/vmm/src/arch/x86_64/gen/mod.rs

@@ -7,9 +7,7 @@
 
 pub mod hyperv;
 pub mod hyperv_tlfs;
-#[allow(non_camel_case_types)]
-#[allow(non_upper_case_globals)]
 pub mod mpspec;
-#[allow(non_upper_case_globals)]
+
 pub mod msr_index;
 pub mod perf_event;

src/vmm/src/arch/x86_64/mod.rs

@@ -18,7 +18,6 @@ pub mod msr;
 /// Logic for configuring x86_64 registers.
 pub mod regs;
 
-#[allow(clippy::all)]
 #[allow(missing_docs)]
 pub mod gen;
 

src/vmm/src/dumbo/mod.rs

@@ -1,8 +1,6 @@
 // Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-#![warn(missing_docs)]
-
 //! Provides helper logic for parsing and writing protocol data units, and minimalist
 //! implementations of a TCP listener, a TCP connection, and an HTTP/1.1 server.
 pub mod pdu;

src/vmm/src/io_uring/mod.rs

@@ -1,8 +1,6 @@
 // Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-#![warn(missing_docs)]
-
 #[allow(clippy::undocumented_unsafe_blocks)]
 mod gen;
 pub mod operation;

src/vmm/src/logger/mod.rs

@@ -1,8 +1,6 @@
 // Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-#![warn(missing_docs)]
-
 //! Crate that implements Firecracker specific functionality as far as logging and metrics
 //! collecting.
 

src/vmm/src/rate_limiter/mod.rs

@@ -1,8 +1,6 @@
 // Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-#![warn(missing_docs)]
-
 use std::os::unix::io::{AsRawFd, RawFd};
 use std::time::{Duration, Instant};
 use std::{fmt, io};

src/vmm/src/snapshot/mod.rs

@@ -1,8 +1,6 @@
 // Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-#![warn(missing_docs)]
-
 //! Provides serialization and deserialization facilities and implements a persistent storage
 //! format for Firecracker state snapshots.
 //!

src/vmm/tests/io_uring.rs

@@ -1,8 +1,6 @@
 // Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-#![allow(clippy::undocumented_unsafe_blocks)]
-
 use std::os::unix::fs::FileExt;
 use std::os::unix::io::AsRawFd;
 use std::thread;

tools/bindgen.sh

@@ -33,7 +33,6 @@ function fc-bindgen {
     non_snake_case,
     clippy::ptr_as_ptr,
     clippy::undocumented_unsafe_blocks,
-    clippy::cast_lossless,
     missing_debug_implementations,
     clippy::tests_outside_test_module
 )]