Skip to content

Commit 847890e

Browse files
committed
[devtool] copy relase artifacts before test run
Signed-off-by: Luminita Voicu <[email protected]>
1 parent c9d14f9 commit 847890e

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

tools/devtool

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -997,8 +997,8 @@ cmd_build_release_archive() {
997997
say "Will start preparing release archive for v$version ..."
998998
get_user_confirmation || die "Aborted."
999999

1000-
# Run tests, build release binaries and strip them from debug symbols.
1001-
( cmd_build --release && cmd_strip && cmd_test ) || die "Aborted."
1000+
# Build release binaries and strip them from debug symbols.
1001+
( cmd_build --release && cmd_strip ) || die "Aborted."
10021002

10031003
release_suffix="v$version-$(uname -m)"
10041004
release_dir="release-$release_suffix"
@@ -1015,19 +1015,30 @@ cmd_build_release_archive() {
10151015
done
10161016

10171017
add_swagger_artifact "$release_dir"
1018-
add_folder_artifact "$release_dir" "test_results" "$release_suffix"
10191018
add_file_artifact "$release_dir" "$seccomp_json" "seccomp-filter-$release_suffix.json"
10201019
for file in "LICENSE" "NOTICE" "THIRD-PARTY"; do
10211020
add_file_artifact "$release_dir" "$file"
10221021
done
10231022

1023+
# Run tests to obtain test reports dir.
1024+
cmd_test || cleanup_release_dir "$release_dir" "Tests failed."
1025+
add_folder_artifact "$release_dir" "test_results" "$release_suffix"
1026+
10241027
# Create release archive.
10251028
archive_name="firecracker-$release_suffix.tgz"
10261029
say "Creating release archive..."
10271030
tar -czf "$archive_name" "$release_dir"
10281031
say "Done. Archive $archive_name successfully created."
10291032
}
10301033

1034+
cleanup_release_dir() {
1035+
release_dir="$1"
1036+
error_msg="$2"
1037+
1038+
rm -rf "$release_dir"
1039+
die "$error_msg"
1040+
}
1041+
10311042
check_file_existence() {
10321043
artifact="$1"
10331044
if [ ! -f "$artifact" ]; then

0 commit comments

Comments
 (0)