Skip to content

Commit 86494fd

Browse files
committed
test: Make test_mmds use correct target version
It has to take snapshots at "snapshot version", not the firecracker version (so 1.3.0 instead of 1.3.1) to pass. Additionally, download the files with the correct permissions (this was preventing the test from passing locally for me) Signed-off-by: Patrick Roy <[email protected]>
1 parent c10b07f commit 86494fd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/integration_tests/functional/test_mmds.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -703,11 +703,11 @@ def test_mmds_snapshot(bin_cloner_path, version):
703703
for firecracker in firecracker_artifacts:
704704
iface_cfg = NetIfaceConfig()
705705
vm_instance = vm_builder.build_vm_nano(net_ifaces=[iface_cfg])
706-
firecracker.download()
706+
firecracker.download(perms=0o555)
707707
jailer = firecracker.jailer()
708-
jailer.download()
708+
jailer.download(perms=0o555)
709709

710-
target_version = firecracker.base_name()[1:]
710+
target_version = firecracker.snapshot_version
711711
# If the version is smaller or equal to 1.0.0, we expect that
712712
# MMDS will be initialised with V1 by default.
713713
if compare_versions(target_version, "1.0.0") <= 0:

0 commit comments

Comments
 (0)