Update types for (in)equality checks

For equalities and inequalities, we can change the types on each side to
always convert to the larger type, which ensures all conversions are
safe.

Signed-off-by: Jonathan Browne <[email protected]>

Author: JBYoshi

src/vmm/src/arch/x86_64/mod.rs

@@ -191,7 +191,7 @@ fn add_e820_entry(
     size: u64,
     mem_type: u32,
 ) -> Result<(), ConfigurationError> {
-    if params.e820_entries >= params.e820_table.len() as u8 {
+    if params.e820_entries as usize >= params.e820_table.len() {
         return Err(ConfigurationError::E820Configuration);
     }
 

src/vmm/src/arch/x86_64/msr.rs

@@ -490,7 +490,7 @@ pub fn set_msrs(vcpu: &VcpuFd, msr_entries: &[kvm_msr_entry]) -> Result<(), MsrE
     vcpu.set_msrs(&msrs)
         .map_err(MsrError::SetMsrs)
         .and_then(|msrs_written| {
-            if msrs_written as u32 == msrs.as_fam_struct_ref().nmsrs {
+            if msrs_written == msrs.as_fam_struct_ref().nmsrs as usize {
                 Ok(())
             } else {
                 Err(MsrError::SetMsrsIncomplete)

src/vmm/src/vstate/vcpu/x86_64.rs

@@ -439,7 +439,7 @@ impl KvmVcpu {
         // per million beacuse it is common for TSC frequency
         // to differ due to calibration at boot time.
         let diff = (i64::from(self.get_tsc_khz()?) - i64::from(state_tsc_freq)).abs();
-        Ok(diff > (f64::from(state_tsc_freq) * TSC_KHZ_TOL).round() as i64)
+        Ok(diff as f64 > (f64::from(state_tsc_freq) * TSC_KHZ_TOL).round())
     }
 
     /// Scale the TSC frequency of this vCPU to the one provided as a parameter.