Skip to content

Commit 97b9de8

Browse files
committed
docs(ci): document usage of depends_on in pipeline generation
Document how we use `depends_on` to make sure that a failure of the Style step does not prevent all the other integration tests from running. Signed-off-by: Patrick Roy <[email protected]>
1 parent b99faaf commit 97b9de8

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.buildkite/common.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,12 @@ def __init__(self, initial_steps=None, **kwargs):
257257
step_build = group("🏗️ Build", build_cmds, **self.per_arch)
258258
self.steps += [step_build, "wait"]
259259

260+
# If we run initial_steps before the "wait" step above, then a failure of the initial steps
261+
# would result in the build not progressing past the "wait" step (as buildkite only proceeds past a wait step
262+
# if everything before it passed). Thus put the initial steps after the "wait" step, but set `"depends_on": null`
263+
# to start running them immediately (e.g. without waiting for the "wait" step to unblock).
264+
#
265+
# See also https://buildkite.com/docs/pipelines/dependencies#explicit-dependencies-in-uploaded-steps
260266
if initial_steps:
261267
for step in initial_steps:
262268
step["depends_on"] = None

0 commit comments

Comments
 (0)