tests: integration tests for drive rescan

Signed-off-by: Alexandra Iordache <[email protected]>

Author: Alexandra Iordache

tests/functional/test_api.py

@@ -285,10 +285,18 @@ def test_api_put_update_post_boot(test_microvm_with_api):
     """ Network interface update is not allowed after boot."""
     assert(not test_microvm.api_session.is_good_response(response.status_code))
 
-    """
-    TODO: Right now, PUT on block device triggers a rescan. After we properly
-    implement the rescan, we have to also check that PUT on /drives fails.
-    """
+    response = test_microvm.api_session.put(
+        test_microvm.blk_cfg_url + '/rootfs',
+        json={
+            'drive_id': 'rootfs',
+            'path_on_host': test_microvm.slot.rootfs_file,
+            'is_root_device': True,
+            'permissions': 'rw',
+            'state': 'Attached'
+        }
+    )
+    """ Block device update is not allowed after boot."""
+    assert(not test_microvm.api_session.is_good_response(response.status_code))
 
 
 def test_rate_limiters_api_config(test_microvm_with_api):
@@ -689,3 +697,50 @@ def test_api_unknown_fields(test_microvm_with_api):
         }
     )
     assert response.status_code == 400
+
+
+def test_api_actions(test_microvm_with_api):
+    """
+    Tests PUT requests to /actions, other than InstanceStart and InstanceHalt.
+    """
+
+    test_microvm = test_microvm_with_api
+    test_microvm.basic_config()
+    """
+    Sets up the microVM with 2 vCPUs, 256 MiB of RAM, 1 network iface and
+    a root file system with the rw permission.
+    """
+
+    test_microvm.put_default_scratch_device()
+
+    response = test_microvm.api_session.put(
+        test_microvm.actions_url,
+        json={
+            'action_type': 'BlockDeviceRescan',
+            'payload': 'scratch',
+        }
+    )
+    """ Rescan operations before the guest boots are not allowed. """
+    assert(not test_microvm.api_session.is_good_response(response.status_code))
+
+    test_microvm.start()
+
+    response = test_microvm.api_session.put(
+        test_microvm.actions_url,
+        json={
+            'action_type': 'BlockDeviceRescan',
+            'payload': 'scratch',
+        }
+    )
+    """ Rescan operations after the guest boots are allowed. """
+    assert(test_microvm.api_session.is_good_response(response.status_code))
+
+    response = test_microvm.api_session.put(
+        test_microvm.actions_url,
+        json={
+            'action_type': 'BlockDeviceRescan',
+            'payload': 'foobar',
+        }
+    )
+    """ Rescan operations on non-existent drives are not allowed. """
+    assert(not test_microvm.api_session.is_good_response(response.status_code))

tests/functional/test_drives.py

@@ -0,0 +1,58 @@
+"""
+Tests that ensure the correctness of operations on /drives resources from the
+guest side.
+"""
+
+from host_tools.network import SSHConnection
+
+
+def test_rescan(test_microvm_with_ssh, network_config):
+    """
+    Tests that triggering a block device rescan makes the guest pick up any
+    changes to the block device's size.
+    """
+
+    test_microvm = test_microvm_with_ssh
+
+    test_microvm.basic_config(net_iface_count=0)
+    """
+    Sets up the microVM with 1 vCPUs, 256 MiB of RAM, 0 network ifaces and
+    a root file system with the rw permission. The network interface is
+    added after we get an unique MAC and IP.
+    """
+    test_microvm.basic_network_config(network_config)
+
+    """ Adds a scratch block device. """
+    test_microvm.put_default_scratch_device()
+
+    test_microvm.start()
+
+    ssh_connection = SSHConnection(test_microvm.slot.ssh_config)
+
+    _check_scratch_size(ssh_connection, test_microvm.slot.sizeof_fsfile('scratch'))
+
+    test_microvm.slot.resize_fsfile('scratch', 512)
+    """ Resizes the filesystem file from 256 MiB (default) to 512 MiB."""
+
+    response = test_microvm.api_session.put(
+        test_microvm.actions_url,
+        json={
+            'action_type': 'BlockDeviceRescan',
+            'payload': 'scratch',
+        }
+    )
+    """ Rescan operations after the guest boots are allowed. """
+    assert(test_microvm.api_session.is_good_response(response.status_code))
+
+    _check_scratch_size(ssh_connection, test_microvm.slot.sizeof_fsfile('scratch'))
+
+    ssh_connection.close()
+
+
+def _check_scratch_size(ssh_connection, size):
+    _, stdout, stderr = ssh_connection.execute_command(
+        "blockdev --getsize64 /dev/vdb"
+    )
+    """ The scratch block device is /dev/vdb in the guest. """
+    assert(stderr.read().decode("utf-8") == '')
+    assert(stdout.readline().strip() == str(size))