refactor: buildkite: rename decorate to depends_on_build

Name more clearly indicate what the parameter does (adding `depends_on`
steps for the shared compilation, and adapting the step commands with an
artifact download).

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

.buildkite/common.py

@@ -259,21 +259,21 @@ def __init__(self, with_build_step=True, **kwargs):
         if with_build_step:
             build_cmds, self.shared_build = shared_build()
             self.build_group_per_arch(
-                "🏗️ Build", build_cmds, decorate=False, key_prefix="build"
+                "🏗️ Build", build_cmds, depends_on_build=False, key_prefix="build"
             )
         else:
             self.shared_build = None
 
-    def add_step(self, step, decorate=True):
+    def add_step(self, step, depends_on_build=True):
         """
         Add a step to the pipeline.
 
         https://buildkite.com/docs/pipelines/step-reference
 
         :param step: a Buildkite step
-        :param decorate: inject needed commands for sharing builds
+        :param depends_on_build: inject needed commands for sharing builds
         """
-        if decorate and isinstance(step, dict):
+        if depends_on_build and isinstance(step, dict):
             step = self._adapt_group(step)
         self.steps.append(step)
         return step
@@ -308,15 +308,17 @@ def build_group(self, *args, **kwargs):
 
         https://buildkite.com/docs/pipelines/group-step
         """
-        decorate = kwargs.pop("decorate", True)
+        depends_on_build = kwargs.pop("depends_on_build", True)
         combined = overlay_dict(self.per_instance, kwargs)
-        return self.add_step(group(*args, **combined), decorate=decorate)
+        return self.add_step(
+            group(*args, **combined), depends_on_build=depends_on_build
+        )
 
     def build_group_per_arch(self, label, *args, **kwargs):
         """
         Build a group, parametrizing over the architectures only.
         """
-        decorate = kwargs.pop("decorate", True)
+        depends_on_build = kwargs.pop("depends_on_build", True)
         key_prefix = kwargs.pop("key_prefix", None)
         combined = overlay_dict(self.per_arch, kwargs)
         grp = group(label, *args, **combined)
@@ -325,7 +327,7 @@ def build_group_per_arch(self, label, *args, **kwargs):
                 step["key"] = (
                     key_prefix + "_" + DEFAULT_INSTANCES[step["agents"]["instance"]]
                 )
-        return self.add_step(grp, decorate=decorate)
+        return self.add_step(grp, depends_on_build=depends_on_build)
 
     def to_dict(self):
         """Render the pipeline as a dictionary."""

.buildkite/pipeline_pr.py

@@ -30,7 +30,7 @@
         "label": "🪶 Style",
         "depends_on": None,
     },
-    decorate=False,
+    depends_on_build=False,
 )
 
 # run sanity build of devtool if Dockerfile is changed
@@ -61,7 +61,7 @@
         platforms=[("al2", "linux_5.10")],
         timeout_in_minutes=300,
         **DEFAULTS_PERF,
-        decorate=False,
+        depends_on_build=False,
     )
     # modify Kani steps' label
     for step in kani_grp["steps"]:
@@ -72,7 +72,7 @@
     pipeline.build_group(
         "📦 Build",
         pipeline.devtool_test(pytest_opts="integration_tests/build/"),
-        decorate=False,
+        depends_on_build=False,
     )
 
     pipeline.build_group(