chore(clippy): enable warn for or_fun_call

"or_fun_call" warns us when a function is called in side a "*_or(...)"
function. In this case the value is computed (which may be expensive),
but is only used if the Result/Option is an Error/None.
In these cases, using the "*_or_else" variant is the best thing to do.

Signed-off-by: Riccardo Mancini <[email protected]>
Signed-off-by: Babis Chalios <[email protected]>

Author: Manciukic

Cargo.toml

@@ -29,6 +29,7 @@ exit = "warn"
 tests_outside_test_module = "warn"
 assertions_on_result_states = "warn"
 error_impl_error = "warn"
+or_fun_call = "warn"
 
 [profile.dev]
 panic = "abort"

src/clippy-tracing/src/main.rs

@@ -260,7 +260,7 @@ impl Error for ExecError {}
 fn exec() -> Result<Option<(PathBuf, usize, usize)>, ExecError> {
     let args = CommandLineArgs::parse();
 
-    let path = args.path.unwrap_or(PathBuf::from("."));
+    let path = args.path.unwrap_or_else(|| PathBuf::from("."));
     for entry_res in WalkDir::new(path).follow_links(true) {
         let entry = entry_res.map_err(ExecError::Entry)?;
         let entry_path = entry.into_path();

src/cpu-template-helper/src/template/verify/mod.rs

@@ -43,7 +43,7 @@ where
     for (key, template_value_filter) in template {
         let config_value_filter = config
             .get(&key)
-            .ok_or(VerifyError::KeyNotFound(key.to_string()))?;
+            .ok_or_else(|| VerifyError::KeyNotFound(key.to_string()))?;
 
         let template_value = template_value_filter.value & template_value_filter.filter;
         let config_value = config_value_filter.value & template_value_filter.filter;

src/vmm/src/vstate/vm.rs

@@ -170,9 +170,9 @@ impl InterruptSourceGroup for MsiVectorGroup {
 
     fn trigger(&self, index: InterruptIndex) -> vm_device::interrupt::Result<()> {
         self.notifier(index)
-            .ok_or_else(|| std::io::Error::other(format!(
-                "trigger: invalid interrupt index {index}"
-            )))?
+            .ok_or_else(|| {
+                std::io::Error::other(format!("trigger: invalid interrupt index {index}"))
+            })?
             .write(1)
     }