Skip to content

Commit af73ec7

Browse files
committed
fix(devtool): exit with error if firecracker fails to build
way too often have I accidentally ran an out dated firecracker binary when testing something because a change I made doesnt compile, but the failure to build firecracker wasn't considered fatal by devtool, and the sheer amount of stuff it prints after compiling pushed the compiler error offscreen. Fix this by exiting if firecracker fails to build. Signed-off-by: Patrick Roy <[email protected]>
1 parent 3602e9e commit af73ec7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/devtool

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -723,6 +723,7 @@ cmd_test() {
723723
cmd_build --release
724724
if [ -n "$BUILDKITE_PULL_REQUEST_BASE_BRANCH" ]; then
725725
cmd_build --release --rev "$BUILDKITE_PULL_REQUEST_BASE_BRANCH"
726+
ok_or_die "Failed to build Firecracker!"
726727
fi
727728
fi
728729

0 commit comments

Comments
 (0)