Skip to content

Commit baa2718

Browse files
[CI] fix skip reason for cpu features
Some tests are checking the CPU and cache topology as well as some basic features. Other tests check the brand string. Updated the skip reason accordingly. Signed-off-by: Andreea Florescu <[email protected]>
1 parent 87a55a0 commit baa2718

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/integration_tests/functional/test_cpu_features.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def _check_cache_topology(test_microvm, num_vcpus_on_lvl_1_cache,
149149

150150
@pytest.mark.skipif(
151151
platform.machine() != "x86_64",
152-
reason="cpu feattures are only customized on x86_64"
152+
reason="Firecracker supports topology and feature masking only on x86_64."
153153
)
154154
def test_1vcpu_ht_disabled(test_microvm_with_ssh, network_config):
155155
"""Check the CPUID for a microvm with the specified config."""
@@ -165,7 +165,7 @@ def test_1vcpu_ht_disabled(test_microvm_with_ssh, network_config):
165165

166166
@pytest.mark.skipif(
167167
platform.machine() != "x86_64",
168-
reason="cpu feattures are only customized on x86_64"
168+
reason="Firecracker supports topology and feature masking only on x86_64."
169169
)
170170
def test_1vcpu_ht_enabled(test_microvm_with_ssh, network_config):
171171
"""Check the CPUID for a microvm with the specified config."""
@@ -181,7 +181,7 @@ def test_1vcpu_ht_enabled(test_microvm_with_ssh, network_config):
181181

182182
@pytest.mark.skipif(
183183
platform.machine() != "x86_64",
184-
reason="cpu feattures are only customized on x86_64"
184+
reason="Firecracker supports topology and feature masking only on x86_64."
185185
)
186186
def test_2vcpu_ht_disabled(test_microvm_with_ssh, network_config):
187187
"""Check the CPUID for a microvm with the specified config."""
@@ -197,7 +197,7 @@ def test_2vcpu_ht_disabled(test_microvm_with_ssh, network_config):
197197

198198
@pytest.mark.skipif(
199199
platform.machine() != "x86_64",
200-
reason="cpu feattures are only customized on x86_64"
200+
reason="Firecracker supports topology and feature masking only on x86_64."
201201
)
202202
def test_2vcpu_ht_enabled(test_microvm_with_ssh, network_config):
203203
"""Check the CPUID for a microvm with the specified config."""
@@ -213,7 +213,7 @@ def test_2vcpu_ht_enabled(test_microvm_with_ssh, network_config):
213213

214214
@pytest.mark.skipif(
215215
platform.machine() != "x86_64",
216-
reason="cpu feattures are only customized on x86_64"
216+
reason="Firecracker supports topology and feature masking only on x86_64."
217217
)
218218
def test_16vcpu_ht_disabled(test_microvm_with_ssh, network_config):
219219
"""Check the CPUID for a microvm with the specified config."""
@@ -229,7 +229,7 @@ def test_16vcpu_ht_disabled(test_microvm_with_ssh, network_config):
229229

230230
@pytest.mark.skipif(
231231
platform.machine() != "x86_64",
232-
reason="cpu feattures are only customized on x86_64"
232+
reason="Firecracker supports topology and feature masking only on x86_64."
233233
)
234234
def test_16vcpu_ht_enabled(test_microvm_with_ssh, network_config):
235235
"""Check the CPUID for a microvm with the specified config."""
@@ -245,7 +245,7 @@ def test_16vcpu_ht_enabled(test_microvm_with_ssh, network_config):
245245

246246
@pytest.mark.skipif(
247247
platform.machine() != "x86_64",
248-
reason="cpu feattures are only customized on x86_64"
248+
reason="The CPU brand string is masked only on x86_64."
249249
)
250250
def test_brand_string(test_microvm_with_ssh, network_config):
251251
"""Ensure good formatting for the guest band string.
@@ -305,7 +305,7 @@ def test_brand_string(test_microvm_with_ssh, network_config):
305305

306306
@pytest.mark.skipif(
307307
platform.machine() != "x86_64",
308-
reason="AVX features are only available on x86_64"
308+
reason="AVX features are available only on x86_64."
309309
)
310310
@pytest.mark.parametrize("cpu_template", ["T2", "C3"])
311311
def test_avx_disabled(test_microvm_with_ssh, network_config, cpu_template):

0 commit comments

Comments
 (0)