Skip to content

Commit bbc18bf

Browse files
committed
test(test_network_latency): dump metrics on ping failure
Looking at Firecracker metrics may help us understand the origin of the issue where a ping attempt fails. Signed-off-by: Nikita Kalyazin <[email protected]>
1 parent 1ccfe46 commit bbc18bf

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tests/integration_tests/performance/test_network_ab.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,11 @@ def test_network_latency(network_microvm, metrics):
7979
f"ping -c {request_per_round} -i {delay} {host_ip}"
8080
)
8181

82-
samples.extend(consume_ping_output(ping_output, request_per_round))
82+
try:
83+
samples.extend(consume_ping_output(ping_output, request_per_round))
84+
except AssertionError:
85+
network_microvm.flush_metrics()
86+
raise
8387

8488
for sample in samples:
8589
metrics.put_metric("ping_latency", sample, "Milliseconds")

0 commit comments

Comments
 (0)