Skip to content

Commit d379eeb

Browse files
committed
refactor(test): Remove detect_fingerprint_change()
`detect_fingerprint_change()` is used only once. Signed-off-by: Takahiro Itazuri <[email protected]>
1 parent 288efd3 commit d379eeb

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

tests/integration_tests/functional/test_cpu_template_helper.py

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,15 @@ def test_cpu_config_dump_vs_actual(
320320
), f"Mismatched MSR for {key:#010x}: {actual=:#066b} vs. {dump=:#066b}"
321321

322322

323-
def detect_fingerprint_change(results_dir, cpu_template_helper, filters=None):
323+
@pytest.mark.no_block_pr
324+
@pytest.mark.skipif(
325+
global_props.host_linux_version not in SUPPORTED_HOST_KERNELS,
326+
reason=f"Supported kernels are {SUPPORTED_HOST_KERNELS}",
327+
)
328+
def test_guest_cpu_config_change(results_dir, cpu_template_helper):
324329
"""
325-
Compare fingerprint files with filters between one taken at the moment and
326-
a baseline file taken in a specific point in time.
330+
Verify that the guest CPU config has not changed since the baseline
331+
fingerprint was gathered.
327332
"""
328333
fname = f"fingerprint_{global_props.cpu_codename}_{global_props.host_linux_version}host.json"
329334

@@ -338,23 +343,6 @@ def detect_fingerprint_change(results_dir, cpu_template_helper, filters=None):
338343
cpu_template_helper.fingerprint_compare(
339344
baseline_path,
340345
fingerprint_path,
341-
filters,
342-
)
343-
344-
345-
@pytest.mark.no_block_pr
346-
@pytest.mark.skipif(
347-
global_props.host_linux_version not in SUPPORTED_HOST_KERNELS,
348-
reason=f"Supported kernels are {SUPPORTED_HOST_KERNELS}",
349-
)
350-
def test_guest_cpu_config_change(results_dir, cpu_template_helper):
351-
"""
352-
Verify that the guest CPU config has not changed since the baseline
353-
fingerprint was gathered.
354-
"""
355-
detect_fingerprint_change(
356-
results_dir,
357-
cpu_template_helper,
358346
["guest_cpu_config"],
359347
)
360348

0 commit comments

Comments
 (0)