test: run all parametrized snapshot tests with mincore snapshots

Now that the test framework correctly differentiates between the need
for rebase and the need for dirty page tracking, start running tests
with mincore snapshots.

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

tests/conftest.py

@@ -427,7 +427,9 @@ def io_engine(request):
     return request.param
 
 
-@pytest.fixture(params=[SnapshotType.DIFF, SnapshotType.FULL])
+@pytest.fixture(
+    params=[SnapshotType.DIFF, SnapshotType.DIFF_MINCORE, SnapshotType.FULL]
+)
 def snapshot_type(request):
     """All possible snapshot types"""
     return request.param

tests/framework/microvm.py

@@ -51,6 +51,7 @@ class SnapshotType(Enum):
 
     FULL = auto()
     DIFF = auto()
+    DIFF_MINCORE = auto()
 
     def __repr__(self):
         cls_name = self.__class__.__name__
@@ -59,7 +60,7 @@ def __repr__(self):
     @property
     def needs_rebase(self) -> bool:
         """Does this snapshot type need rebasing on top of a base snapshot before restoration?"""
-        return self == SnapshotType.DIFF
+        return self in [SnapshotType.DIFF, SnapshotType.DIFF_MINCORE]
 
     @property
     def needs_dirty_page_tracking(self) -> bool:
@@ -72,7 +73,7 @@ def api_type(self) -> str:
         match self:
             case SnapshotType.FULL:
                 return "Full"
-            case SnapshotType.DIFF:
+            case SnapshotType.DIFF | SnapshotType.DIFF_MINCORE:
                 return "Diff"
 
 

tests/integration_tests/performance/test_snapshot.py

@@ -284,7 +284,7 @@ def test_snapshot_create_latency(
     match snapshot_type:
         case SnapshotType.FULL:
             metric = "full_create_snapshot"
-        case SnapshotType.DIFF:
+        case SnapshotType.DIFF | SnapshotType.DIFF_MINCORE:
             metric = "diff_create_snapshot"
 
     for _ in range(ITERATIONS):