Skip to content

Commit e34ff13

Browse files
committed
tests: deprecate test_microvm_with_ssh
The same can be done with test_microvm_with_api Signed-off-by: Pablo Barbáchano <[email protected]>
1 parent 81dea55 commit e34ff13

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

tests/integration_tests/functional/test_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1373,7 +1373,7 @@ def test_get_full_config(test_microvm_with_api):
13731373
assert response.json() == expected_cfg
13741374

13751375

1376-
def test_map_private_seccomp_regression(test_microvm_with_ssh):
1376+
def test_map_private_seccomp_regression(test_microvm_with_api):
13771377
"""
13781378
Seccomp mmap MAP_PRIVATE regression test.
13791379
@@ -1383,7 +1383,7 @@ def test_map_private_seccomp_regression(test_microvm_with_ssh):
13831383
13841384
@type: regression
13851385
"""
1386-
test_microvm = test_microvm_with_ssh
1386+
test_microvm = test_microvm_with_api
13871387
test_microvm.jailer.extra_args.update(
13881388
{"http-api-max-payload-size": str(1024 * 1024 * 2)}
13891389
)

tests/integration_tests/security/test_jail.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -579,13 +579,13 @@ def test_args_resource_limits(test_microvm_with_initrd):
579579
check_limits(pid, NOFILE, FSIZE)
580580

581581

582-
def test_negative_file_size_limit(test_microvm_with_ssh):
582+
def test_negative_file_size_limit(test_microvm_with_api):
583583
"""
584584
Test creating snapshot file fails when size exceeds `fsize` limit.
585585
586586
@type: negative
587587
"""
588-
test_microvm = test_microvm_with_ssh
588+
test_microvm = test_microvm_with_api
589589
test_microvm.jailer.resource_limits = ["fsize=1024"]
590590

591591
test_microvm.spawn()
@@ -623,13 +623,13 @@ def test_negative_file_size_limit(test_microvm_with_ssh):
623623
assert False, "Negative test failed"
624624

625625

626-
def test_negative_no_file_limit(test_microvm_with_ssh):
626+
def test_negative_no_file_limit(test_microvm_with_api):
627627
"""
628628
Test microVM is killed when exceeding `no-file` limit.
629629
630630
@type: negative
631631
"""
632-
test_microvm = test_microvm_with_ssh
632+
test_microvm = test_microvm_with_api
633633
test_microvm.jailer.resource_limits = ["no-file=3"]
634634

635635
# pylint: disable=W0703
@@ -642,13 +642,13 @@ def test_negative_no_file_limit(test_microvm_with_ssh):
642642
assert False, "Negative test failed"
643643

644644

645-
def test_new_pid_ns_resource_limits(test_microvm_with_ssh):
645+
def test_new_pid_ns_resource_limits(test_microvm_with_api):
646646
"""
647647
Test that Firecracker process inherits jailer resource limits.
648648
649649
@type: security
650650
"""
651-
test_microvm = test_microvm_with_ssh
651+
test_microvm = test_microvm_with_api
652652

653653
test_microvm.jailer.new_pid_ns = True
654654
test_microvm.jailer.resource_limits = RESOURCE_LIMITS

0 commit comments

Comments
 (0)