refactor(test): capture screen log via file copy

Copy the screen log file (which contains firecracker's stdout/guest
dmesg if non-daemonized / no log file specified) to the test_results
directory, to be included in artifacts, instead of explicitly reading
one file and subsequently writing another file in Python code.

Signed-off-by: Patrick Roy <[email protected]>

Author: roypat

tests/conftest.py

@@ -392,6 +392,8 @@ def microvm_factory(request, record_property, results_dir, netns_factory):
                 utils.run_cmd(["dmesg", "-dPx"]).stdout
             )
             shutil.copy(f"/firecracker/build/img/{platform.machine()}/id_rsa", uvm_data)
+            if Path(uvm.screen_log).exists():
+                shutil.copy(uvm.screen_log, uvm_data)
 
             uvm_root = Path(uvm.chroot())
             for item in os.listdir(uvm_root):
@@ -400,9 +402,6 @@ def microvm_factory(request, record_property, results_dir, netns_factory):
                     continue
                 dst = uvm_data / item
                 shutil.copy(src, dst)
-                console_data = uvm.console_data
-                if console_data:
-                    uvm_data.joinpath("guest-console.log").write_text(console_data)
 
     uvm_factory.kill()
 

tests/framework/microvm.py

@@ -458,16 +458,6 @@ def log_data(self):
             return ""
         return self.log_file.read_text()
 
-    @property
-    def console_data(self):
-        """Return the output of microVM's console"""
-        if self.screen_log is None:
-            return None
-        file = Path(self.screen_log)
-        if not file.exists():
-            return None
-        return file.read_text(encoding="utf-8")
-
     @property
     def state(self):
         """Get the InstanceInfo property and return the state field."""