Skip to content

Commit e9c2dd9

Browse files
committed
test: Don't disable turbo on AMD instances
We would like to observer the effect on stability of our performance tests on AMD instances with turbo not disabled. Signed-off-by: Jack Thomson <[email protected]>
1 parent 7c0dc1e commit e9c2dd9

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

tools/devtool

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -628,11 +628,10 @@ apply_linux_61_tweaks() {
628628

629629
# Modifies the processors CPU governor and P-state configuration (x86_64 only) for consistent performance. This means
630630
# - Disable turbo boost (Intel only) by writing 1 to /sys/devices/system/cpu/intel_pstate/no_turbo
631-
# - Disable turbo boost (AMD only) by writing 0 to /sys/devices/system/cpu/cpufreq/boost
632631
# - Lock the CPUs' P-state to the highest non-turbo one (Intel only) by writing 100 to /sys/devices/system/cpu/intel_pstate/{min,max}_perf_pct
633632
# - Set the cpu frequency governor to performance by writing "performance" to /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
634633
apply_performance_tweaks() {
635-
# m6a instances do not support the amd_pstate driver (yet), so nothing we can do there
634+
# AMD instances do not support the amd_pstate driver (yet), so nothing we can do there
636635
if [[ -d /sys/devices/system/cpu/intel_pstate ]]; then
637636
# Disable turbo boost. Some of our tests are performance tests, and we want minimum variability wrt processor frequency
638637
# See also https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/processor_state_control.html
@@ -647,8 +646,6 @@ apply_performance_tweaks() {
647646
# https://www.kernel.org/doc/html/v4.12/admin-guide/pm/intel_pstate.html
648647
echo 100 |sudo tee /sys/devices/system/cpu/intel_pstate/min_perf_pct &> /dev/null
649648
echo 100 |sudo tee /sys/devices/system/cpu/intel_pstate/max_perf_pct &> /dev/null
650-
elif [[ -f /sys/devices/system/cpu/cpufreq/boost ]]; then
651-
echo 0 |sudo tee /sys/devices/system/cpu/cpufreq/boost &> /dev/null
652649
fi
653650

654651
# The governor is a linux component that can adjust CPU frequency. "performance" tells it to always run CPUs at
@@ -665,8 +662,6 @@ unapply_performance_tweaks() {
665662
# restore p-state limits
666663
echo $MIN_PERF_PCT |sudo tee /sys/devices/system/cpu/intel_pstate/min_perf_pct &> /dev/null
667664
echo $MAX_PERF_PCT |sudo tee /sys/devices/system/cpu/intel_pstate/max_perf_pct &> /dev/null
668-
elif [[ -f /sys/devices/system/cpu/cpufreq/boost ]]; then
669-
echo 1 | sudo tee /sys/devices/system/cpu/cpufreq/boost &> /dev/null
670665
fi
671666

672667
# We do not reset the governor, as keeping track of each CPUs configured governor is not trivial here. On our CI

0 commit comments

Comments
 (0)