Skip to content

Commit f59717c

Browse files
zulinx86roypat
authored andcommitted
doc: Use a valid bitmap for vcpu_features
As seen in #4925, setting the least significant bits of vcpu_features field to 0 make secondary CPUs not work. There is no reason to use such an invalid example in doc. The sample in doc intended to enable PAC (Pointer Authentication) since it checks capabilities 171 and 172 [2]. Thus, not set the other bits than bits 5 and 6. [1]: https://elixir.bootlin.com/linux/v6.12.1/source/include/uapi/linux/kvm.h#L868-L869 [2]: https://elixir.bootlin.com/linux/v6.12.1/source/arch/arm64/include/uapi/asm/kvm.h#L108-L109 Signed-off-by: Takahiro Itazuri <[email protected]>
1 parent 761909d commit f59717c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/cpu_templates/cpu-templates.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ curl --unix-socket /tmp/firecracker.socket -i \
180180
-H 'Content-Type: application/json' \
181181
-d '{
182182
"kvm_capabilities": ["171", "172"],
183-
"vcpu_features": [{ "index": 0, "bitmap": "0b1100000" }]
183+
"vcpu_features": [{ "index": 0, "bitmap": "0b11xxxxx" }]
184184
"reg_modifiers": [
185185
{
186186
"addr": "0x603000000013c020",

docs/cpu_templates/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"bitmap": {
2727
"description": "Bitmap for modifying the 32 bit field in kvm_vcpu_init::features. Must be in the format `0b[01x]{1,32}`. Corresponding bits will be cleared (`0`), set (`1`) or left intact (`x`). (`_`) can be used as a separator.",
2828
"type": "string",
29-
"examples": ["0b1100000"]
29+
"examples": ["0b11xxxxx"]
3030
}
3131
}
3232
}

0 commit comments

Comments
 (0)