Skip to content

Commit fc55a48

Browse files
committed
test: increase cases for test_population_latency
Gathering more data should make the A/B test more stable and avoid intermittent failures. Signed-off-by: Babis Chalios <[email protected]>
1 parent 69522c8 commit fc55a48

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

tests/integration_tests/performance/test_snapshot_ab.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,12 @@ def test_restore_latency(
142142
@pytest.mark.parametrize("uffd_handler", [None, "on_demand", "fault_all"])
143143
@pytest.mark.parametrize("huge_pages", HugePagesConfig)
144144
def test_post_restore_latency(
145-
microvm_factory, rootfs, guest_kernel_linux_5_10, metrics, uffd_handler, huge_pages
145+
microvm_factory,
146+
rootfs,
147+
guest_kernel_linux_5_10,
148+
metrics,
149+
uffd_handler,
150+
huge_pages,
146151
):
147152
"""Collects latency metric of post-restore memory accesses done inside the guest"""
148153
if huge_pages != HugePagesConfig.NONE and uffd_handler is None:
@@ -190,11 +195,20 @@ def test_post_restore_latency(
190195

191196
@pytest.mark.nonci
192197
@pytest.mark.parametrize("huge_pages", HugePagesConfig)
198+
@pytest.mark.parametrize(
199+
("vcpus", "mem"), [(1, 128), (1, 1024), (2, 2048), (3, 4096), (4, 6144)]
200+
)
193201
def test_population_latency(
194-
microvm_factory, rootfs, guest_kernel_linux_5_10, metrics, huge_pages
202+
microvm_factory,
203+
rootfs,
204+
guest_kernel_linux_5_10,
205+
metrics,
206+
huge_pages,
207+
vcpus,
208+
mem,
195209
):
196210
"""Collects population latency metrics (e.g. how long it takes UFFD handler to fault in all memory)"""
197-
test_setup = SnapshotRestoreTest(mem=128, vcpus=1, huge_pages=huge_pages)
211+
test_setup = SnapshotRestoreTest(mem=mem, vcpus=vcpus, huge_pages=huge_pages)
198212
vm = test_setup.boot_vm(microvm_factory, guest_kernel_linux_5_10, rootfs)
199213

200214
metrics.set_dimensions(

0 commit comments

Comments
 (0)