Skip to content

Commit ff5213e

Browse files
committed
fix: do criterion benchmark comparision the correct way around
The optional criterion benchmark A/B-test had swapped the "A" and "B" data, causing regressions to show up as improvements and improvements to show up as regressions. See also [1] for a documentation of the criterion commandline arguments. [1]: https://bheisler.github.io/criterion.rs/book/user_guide/command_line_options.html#baselines Fixes: b6c0d43 Signed-off-by: Patrick Roy <[email protected]>
1 parent e4c0b9b commit ff5213e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/integration_tests/performance/test_benchmarks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def compare_results(location_a_baselines: Path, location_b_baselines: Path):
7979
_, stdout, _ = cargo(
8080
"bench",
8181
f"--all --target {platform.machine()}-unknown-linux-musl",
82-
"--load-baseline a_baseline --baseline b_baseline",
82+
"--baseline a_baseline --load-baseline b_baseline",
8383
)
8484

8585
regressions_only = "\n\n".join(

0 commit comments

Comments
 (0)