From b76bd804ddbaa29a0af3cc5136fc8b86d436840c Mon Sep 17 00:00:00 2001 From: Riccardo Mancini Date: Wed, 20 Nov 2024 12:00:41 +0000 Subject: [PATCH 1/2] fix: add vcpu_features and kvm_capabilites to swagger These fields were added in #3967 but the Swagger API definition was not updated. This patch fixes the API definition. Also, the field type is changed from "string" to "object", as it has properties and thus can't be a string. Signed-off-by: Riccardo Mancini --- src/firecracker/swagger/firecracker.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/firecracker/swagger/firecracker.yaml b/src/firecracker/swagger/firecracker.yaml index 06f449db431..20bad48bf64 100644 --- a/src/firecracker/swagger/firecracker.yaml +++ b/src/firecracker/swagger/firecracker.yaml @@ -840,7 +840,7 @@ definitions: default: "None" CpuConfig: - type: string + type: object description: The CPU configuration template defines a set of bit maps as modifiers of flags accessed by register to be disabled/enabled for the microvm. @@ -854,6 +854,12 @@ definitions: reg_modifiers: type: object description: A collection of registers to be modified. (aarch64) + vcpu_features: + type: object + description: A collection of vcpu features to be modified. (aarch64) + kvm_capabilities: + type: object + description: A collection of kvm capabilities to be modified. (aarch64) Drive: type: object From 11cf18d26e3abd770f7c6f32b97cd95e91174da8 Mon Sep 17 00:00:00 2001 From: Riccardo Mancini Date: Wed, 20 Nov 2024 16:16:17 +0000 Subject: [PATCH 2/2] chore: add changelog entry for swagger CpuConfig fix Add an entry to mention that we fixed the Swagger API definition. Signed-off-by: Riccardo Mancini --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7da89123eab..6e7be8f518f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,9 @@ and this project adheres to ### Fixed +- [#4921](https://github.com/firecracker-microvm/firecracker/pull/4921): Fixed + swagger `CpuConfig` definition to include missing aarch64-specific fields. + ## \[1.10.1\] ### Changed