-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: fix Firecracker version and rootfs #4928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
roypat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ext4 stuff works for me now, but the SSH commands at the end seem broken. It promps me for a password:
roypat@ua2d7e1a6107c5b:~/test$ ssh -i ./ubuntu-24.04.id_rsa [email protected]
[email protected]'s password:
During the last change we missed updating the Firecracker CI version. Also keep the rootfs as ext4 for the rest of the guide. Fixes: a69595f Signed-off-by: Pablo Barbáchano <[email protected]>
I see. The issue is the owner of files in the rootfs is not root. Should be fixed in the latest revision. |
The last version works! Therefore LGTM But is laying around a directory tree fully owned by root. That might be confusing for some users. Unfortunately I haven't found any solution that does not make the process more complex (like a disk image file). |
roypat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now, thanks a bunch, Pablo!
During the last change we missed updating the Firecracker CI version.
Also keep the rootfs as ext4 for the rest of the guide.
Fixes: a69595f
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.