Skip to content

Conversation

@pb8o
Copy link
Contributor

@pb8o pb8o commented Nov 26, 2024

During the last change we missed updating the Firecracker CI version.

Also keep the rootfs as ext4 for the rest of the guide.

Fixes: a69595f

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Type: Documentation Indicates a need for improvements or additions to documentation Type: Fix Indicates a fix to existing code labels Nov 26, 2024
@pb8o pb8o self-assigned this Nov 26, 2024
@pb8o pb8o marked this pull request as ready for review November 26, 2024 16:38
@pb8o pb8o added the Status: Awaiting author Indicates that an issue or pull request requires author action label Nov 26, 2024
@pb8o pb8o added Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Nov 26, 2024
Manciukic
Manciukic previously approved these changes Nov 26, 2024
@roypat roypat linked an issue Nov 27, 2024 that may be closed by this pull request
3 tasks
roypat
roypat previously approved these changes Nov 27, 2024
Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ext4 stuff works for me now, but the SSH commands at the end seem broken. It promps me for a password:

roypat@ua2d7e1a6107c5b:~/test$ ssh -i ./ubuntu-24.04.id_rsa [email protected]
[email protected]'s password: 

@pb8o pb8o dismissed stale reviews from roypat and Manciukic via 8b2d840 November 27, 2024 09:03
During the last change we missed updating the Firecracker CI version.

Also keep the rootfs as ext4 for the rest of the guide.

Fixes: a69595f

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o
Copy link
Contributor Author

pb8o commented Nov 27, 2024

The ext4 stuff works for me now, but the SSH commands at the end seem broken. It promps me for a password:

roypat@ua2d7e1a6107c5b:~/test$ ssh -i ./ubuntu-24.04.id_rsa [email protected]
[email protected]'s password: 

I see. The issue is the owner of files in the rootfs is not root. Should be fixed in the latest revision.

@pb8o pb8o requested review from Manciukic and roypat November 27, 2024 09:22
@Silvanoc
Copy link

The ext4 stuff works for me now, but the SSH commands at the end seem broken. It promps me for a password:

roypat@ua2d7e1a6107c5b:~/test$ ssh -i ./ubuntu-24.04.id_rsa [email protected]
[email protected]'s password: 

I see. The issue is the owner of files in the rootfs is not root. Should be fixed in the latest revision.

The last version works! Therefore LGTM

But is laying around a directory tree fully owned by root. That might be confusing for some users. Unfortunately I haven't found any solution that does not make the process more complex (like a disk image file).

Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thanks a bunch, Pablo!

@roypat roypat merged commit 63ea863 into firecracker-microvm:main Nov 27, 2024
5 checks passed
@pb8o pb8o deleted the fix-quickstart branch January 22, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] "Getting Started" guide trying to write on SquashFS

4 participants