devtool: Build A and B binaries if $do_build is true #4998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
9 tasks
roypat
force-pushed
the
functional-ab-locally
branch
from
4a4bacc to
f414489
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4998 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 248 248
Lines 27839 27839
=======================================
Hits 23371 23371
Misses 4468 4468
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
previously approved these changes
Jan 16, 2025
roypat
added
the
Status: Awaiting review
If `cmd_test` is instructed to build its own binaries (e.g. being ran outside of CI), and the environment specifies that A/B-tests should be ran, then we not only need to build the currently checked out commit (the "B" revision), but also an "A" binary based on the value of the `BUILDKITE_PULL_REQUEST_BASE_BRANCH` environment variable. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
functional-ab-locally
branch
from
f414489 to
37a90da
Compare
bchalios
previously approved these changes
Jan 16, 2025
pb8o
previously approved these changes
Jan 16, 2025
A quick blurb about which environment variables need to be set to run things like test_vulnerabilities.py locally. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
functional-ab-locally
branch
from
37a90da to
7d654b9
Compare
kalyazin
approved these changes
Jan 16, 2025
bchalios
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
cmd_testis instructed to build its own binaries (e.g. being ranoutside of CI), and the environment specifies that A/B-tests should
be ran, then we not only need to build the currently checked out commit
(the "B" revision), but also an "A" binary based on the value of the
BUILDKITE_PULL_REQUEST_BASE_BRANCHenvironment variable.Signed-off-by: Patrick Roy [email protected]## Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.