Update kernel install script to work with AL2023 #5134
Merged
+85
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5134 +/- ##
======================================================
Coverage 83.03% 83.03%
======================================================
Files 250 250
Lines 26911 26911
======================================================
Hits 22345 22345
Misses 4566 4566
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackThomson2
added
the
Status: Awaiting review
kalyazin
reviewed
Apr 2, 2025
roypat
force-pushed
the
feature/secret-hiding
branch
from
bf38d65 to
cfd4d8b
Compare
roypat
force-pushed
the
feature/al2023_kernel_install
branch
from
8d2b809 to
f3e5f0d
Compare
Update the build script to allow us to install the secret hidden kernels onto Amazon Linux 2023 instances. We have to as part of this include a script to download and install ena drivers for the instance to allow us to boot. Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
feature/al2023_kernel_install
branch
from
f3e5f0d to
c0cb176
Compare
kalyazin
approved these changes
Apr 4, 2025
zulinx86
approved these changes
Apr 4, 2025
JackThomson2
merged commit 4738610
into
firecracker-microvm:feature/secret-hiding
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated our kernel install script to now work for AL2023.
To run on AL2023 we need to also install the ENA driver to allow us to connect to the instance after boot. So the script will now do this during the installation process.
I have been able to run this script in my ec2 image builder pipeline and boot metals from the generated AMIS
Signed-off-by: Jack Thomson [email protected]
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.