Merge pull request #88 from austinvazquez/remove-copyright-dates

chore: remove copyright dates

Author: austinvazquez

.github/workflows/go.yml

@@ -24,6 +24,9 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
+    - name: Run static analysis
+      run: make lint
+
     - name: Build
       run: make all
 

.gitignore

@@ -1,2 +1,3 @@
+bin/
 firectl
 firectl.sha256

.headers/go.txt

@@ -0,0 +1,12 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License"). You may
+// not use this file except in compliance with the License. A copy of the
+// License is located at
+//
+//	http://aws.amazon.com/apache2.0/
+//
+// or in the "license" file accompanying this file. This file is distributed
+// on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+// express or implied. See the License for the specific language governing
+// permissions and limitations under the License.

.headers/makefile.txt

@@ -0,0 +1,12 @@
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"). You may
+# not use this file except in compliance with the License. A copy of the
+# License is located at
+#
+#	http://aws.amazon.com/apache2.0/
+#
+# or in the "license" file accompanying this file. This file is distributed
+# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+# express or implied. See the License for the specific language governing
+# permissions and limitations under the License.

CONTRIBUTING.md

@@ -33,8 +33,9 @@ To send us a pull request, please:
 2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
 3. Ensure local tests pass.
 4. Commit to your fork using clear commit messages.
-5. Send us a pull request, answering any default questions in the pull request interface.
-6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
+5. Verify all commit messages include [DCO signature](#sign-your-work)
+6. Send us a pull request, answering any default questions in the pull request interface.
+7. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
 
 GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and 
 [creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
@@ -50,6 +51,61 @@ For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of
 [email protected] with any additional questions or comments.
 
 
+## Sign your work
+
+The sign-off is a simple line at the end of the explanation for the patch. Your
+signature certifies that you wrote the patch or otherwise have the right to pass
+it on as an open-source patch. If you can certify
+the below (from [developercertificate.org](http://developercertificate.org/)):
+
+```
+Developer Certificate of Origin
+Version 1.1
+
+Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
+660 York Street, Suite 102,
+San Francisco, CA 94110 USA
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+Developer's Certificate of Origin 1.1
+
+By making a contribution to this project, I certify that:
+
+(a) The contribution was created in whole or in part by me and I
+    have the right to submit it under the open source license
+    indicated in the file; or
+
+(b) The contribution is based upon previous work that, to the best
+    of my knowledge, is covered under an appropriate open source
+    license and I have the right under that license to submit that
+    work with modifications, whether created in whole or in part
+    by me, under the same open source license (unless I am
+    permitted to submit under a different license), as indicated
+    in the file; or
+
+(c) The contribution was provided directly to me by some other
+    person who certified (a), (b) or (c) and I have not modified
+    it.
+
+(d) I understand and agree that this project and the contribution
+    are public and that a record of the contribution (including all
+    personal information I submit with it, including my sign-off) is
+    maintained indefinitely and may be redistributed consistent with
+    this project or the open source license(s) involved.
+```
+
+Then you just add a line to every git commit message:
+
+    Signed-off-by: Joe Smith <[email protected]>
+
+Use your real name (sorry, no pseudonyms or anonymous contributions.)
+
+If you set your `user.name` and `user.email` git configs, you can sign your
+commit automatically with `git commit -s`.
+
+
 ## Security issue notifications
 If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
 

Makefile

@@ -1,4 +1,4 @@
-# Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License"). You may
 # not use this file except in compliance with the License. A copy of the
@@ -12,8 +12,8 @@
 # permissions and limitations under the License.
 SRCFILES := *.go go.sum go.mod
 
-INSTALLROOT ?= /usr/local
-BINDIR ?= $(INSTALLROOT)/bin
+INSTALLPATH ?= /usr/local/bin
+BINPATH:=$(abspath ./bin)
 
 all: firectl
 
@@ -36,13 +36,25 @@ build-in-docker:
 test:
 	go test -v ./...
 
-lint:
-	golint $(SRCFILES)
+$(BINPATH)/ltag:
+	GOBIN=$(BINPATH) GO111MODULE=off go get -u github.com/kunalkushwaha/ltag
+
+$(BINPATH)/git-validation:
+	GOBIN=$(BINPATH) GO111MODULE=off go get -u github.com/vbatts/git-validation
+
+$(BINPATH)/golangci-lint:
+	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(BINPATH) v1.46.2
+	$(BINPATH)/golangci-lint --version
+
+lint: $(BINPATH)/ltag $(BINPATH)/git-validation $(BINPATH)/golangci-lint
+	$(BINPATH)/ltag -v -t ./.headers -check
+	$(BINPATH)/git-validation -q -run DCO,short-subject -range HEAD~3..HEAD
+	$(BINPATH)/golangci-lint run
 
 clean:
 	go clean
 
 install:
-	install -o root -g root -m755 firectl $(BINDIR)/
+	install -o root -g root -m755 -t $(INSTALLPATH) firectl
 
 .PHONY: all clean install build-in-docker test lint release

NOTICE

@@ -1,2 +1,2 @@
 Firectl
-Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. 
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. 

errors.go

@@ -1,4 +1,4 @@
-// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License"). You may
 // not use this file except in compliance with the License. A copy of the

main.go

@@ -1,4 +1,4 @@
-// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License"). You may
 // not use this file except in compliance with the License. A copy of the
@@ -134,10 +134,16 @@ func runVMM(ctx context.Context, opts *options) error {
 	if err := m.Start(vmmCtx); err != nil {
 		return fmt.Errorf("Failed to start machine: %v", err)
 	}
-	defer m.StopVMM()
+	defer func() {
+		if err := m.StopVMM(); err != nil {
+			log.Errorf("An error occurred while stopping Firecracker VMM: %v", err)
+		}
+	}()
 
 	if opts.validMetadata != nil {
-		m.SetMetadata(vmmCtx, opts.validMetadata)
+		if err := m.SetMetadata(vmmCtx, opts.validMetadata); err != nil {
+			log.Errorf("An error occurred while setting Firecracker VM metadata: %v", err)
+		}
 	}
 
 	installSignalHandlers(vmmCtx, m)
@@ -162,10 +168,14 @@ func installSignalHandlers(ctx context.Context, m *firecracker.Machine) {
 			switch s := <-c; {
 			case s == syscall.SIGTERM || s == os.Interrupt:
 				log.Printf("Caught signal: %s, requesting clean shutdown", s.String())
-				m.Shutdown(ctx)
+				if err := m.Shutdown(ctx); err != nil {
+					log.Errorf("An error occurred while shutting down Firecracker VM: %v", err)
+				}
 			case s == syscall.SIGQUIT:
 				log.Printf("Caught signal: %s, forcing shutdown", s.String())
-				m.StopVMM()
+				if err := m.StopVMM(); err != nil {
+					log.Errorf("An error occurred while stopping Firecracker VMM: %v", err)
+				}
 			}
 		}
 	}()

main_test.go

@@ -1,4 +1,4 @@
-// Copyright 2018-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License"). You may
 // not use this file except in compliance with the License. A copy of the