gui: split out bad bundles in sankey

Author: jherrera-jump

src/api/entities.ts

@@ -120,6 +120,7 @@ export const txnWaterfallOutSchema = z.object({
   resolv_ancient: z.number(),
   resolv_retained: z.number(),
   pack_invalid: z.number(),
+  pack_invalid_bundle: z.number(),
   pack_retained: z.number(),
   pack_leader_slow: z.number(),
   pack_wait_full: z.number(),

src/features/Overview/SlotPerformance/SlotSankey/consts.ts

@@ -34,6 +34,7 @@ export const enum SlotNode {
   ResolvNoLedger = "No ledger",
   ResolvRetained = "Unresolved:resolv",
   PackInvalid = "Unpackable",
+  PackInvalidBundle = "Bad Bundle",
   PackExpired = "Expired:pack",
   PackRetained = "Buffered:pack",
   PackLeaderSlow = "Buffer full",
@@ -72,6 +73,7 @@ export const droppedSlotNodes: SlotNode[] = [
   SlotNode.ResolvNoLedger,
   SlotNode.ResolvRetained,
   SlotNode.PackInvalid,
+  SlotNode.PackInvalidBundle,
   SlotNode.PackExpired,
   SlotNode.PackRetained,
   SlotNode.PackLeaderSlow,
@@ -114,6 +116,7 @@ export const slotNodes = [
   { id: SlotNode.ResolvExpired, labelPositionOverride: "right" },
   { id: SlotNode.ResolvNoLedger, labelPositionOverride: "right" },
   { id: SlotNode.PackInvalid, labelPositionOverride: "right" },
+  { id: SlotNode.PackInvalidBundle, labelPositionOverride: "right" },
   { id: SlotNode.PackExpired, labelPositionOverride: "right" },
   { id: SlotNode.PackLeaderSlow, labelPositionOverride: "right" },
   { id: SlotNode.PackWaitFull, labelPositionOverride: "right" },

src/features/Overview/SlotPerformance/SlotSankey/index.tsx

@@ -87,6 +87,7 @@ function getResolvOut(out: TxnWaterfallOut, resolvRetainedOut: number) {
 function getPackOut(out: TxnWaterfallOut) {
   return (
     out.pack_invalid +
+    out.pack_invalid_bundle +
     out.pack_expired +
     out.pack_leader_slow +
     out.pack_retained +
@@ -284,6 +285,11 @@ function getLinks(
       target: SlotNode.PackInvalid,
       value: getValue(waterfall.out.pack_invalid),
     },
+    {
+      source: SlotNode.Pack,
+      target: SlotNode.PackInvalidBundle,
+      value: getValue(waterfall.out.pack_invalid_bundle),
+    },
     {
       source: SlotNode.Pack,
       target: SlotNode.PackExpired,