Skip to content

Commit 315e29b

Browse files
quic: optionally leave timed out conns allocated
free pkt_meta when conn freed
1 parent d3aabae commit 315e29b

14 files changed

+617
-331
lines changed

book/api/metrics-generated.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,13 @@
113113
| <span class="metrics-name">quic_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">abort</span>"} | gauge | The number of QUIC connections in each state. (connection terminating due to error) |
114114
| <span class="metrics-name">quic_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">close_&#8203;pending</span>"} | gauge | The number of QUIC connections in each state. (connection is closing) |
115115
| <span class="metrics-name">quic_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">dead</span>"} | gauge | The number of QUIC connections in each state. (connection about to be freed) |
116+
| <span class="metrics-name">quic_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">timeout</span>"} | gauge | The number of QUIC connections in each state. (connection timed out) |
116117
| <span class="metrics-name">quic_&#8203;connections_&#8203;created</span> | counter | The total number of connections that have been created. |
117118
| <span class="metrics-name">quic_&#8203;connections_&#8203;closed</span> | counter | Number of connections gracefully closed. |
118119
| <span class="metrics-name">quic_&#8203;connections_&#8203;aborted</span> | counter | Number of connections aborted. |
119120
| <span class="metrics-name">quic_&#8203;connections_&#8203;timed_&#8203;out</span> | counter | Number of connections timed out. |
121+
| <span class="metrics-name">quic_&#8203;connections_&#8203;timeout_&#8203;revived</span> | counter | Number of connections revived after timing out. |
122+
| <span class="metrics-name">quic_&#8203;connections_&#8203;timeout_&#8203;freed</span> | counter | Number of connections freed after timing out. |
120123
| <span class="metrics-name">quic_&#8203;connections_&#8203;retried</span> | counter | Number of connections established with retry. |
121124
| <span class="metrics-name">quic_&#8203;connection_&#8203;error_&#8203;no_&#8203;slots</span> | counter | Number of connections that failed to create due to lack of slots. |
122125
| <span class="metrics-name">quic_&#8203;connection_&#8203;error_&#8203;retry_&#8203;fail</span> | counter | Number of connections that failed during retry (e.g. invalid token). |
@@ -782,10 +785,13 @@
782785
| <span class="metrics-name">send_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">abort</span>"} | gauge | Number of QUIC connections in each state (connection terminating due to error) |
783786
| <span class="metrics-name">send_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">close_&#8203;pending</span>"} | gauge | Number of QUIC connections in each state (connection is closing) |
784787
| <span class="metrics-name">send_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">dead</span>"} | gauge | Number of QUIC connections in each state (connection about to be freed) |
788+
| <span class="metrics-name">send_&#8203;connections_&#8203;state</span><br/>{quic_&#8203;conn_&#8203;state="<span class="metrics-enum">timeout</span>"} | gauge | Number of QUIC connections in each state (connection timed out) |
785789
| <span class="metrics-name">send_&#8203;connections_&#8203;created</span> | counter | Total count of QUIC connections created |
786790
| <span class="metrics-name">send_&#8203;connections_&#8203;closed</span> | counter | Total count of QUIC connections closed |
787791
| <span class="metrics-name">send_&#8203;connections_&#8203;aborted</span> | counter | Total count of QUIC connections aborted |
788792
| <span class="metrics-name">send_&#8203;connections_&#8203;timed_&#8203;out</span> | counter | Total count of QUIC connections timed out |
793+
| <span class="metrics-name">send_&#8203;connections_&#8203;timeout_&#8203;revived</span> | counter | Total count of QUIC connections revived after timing out |
794+
| <span class="metrics-name">send_&#8203;connections_&#8203;timeout_&#8203;freed</span> | counter | Total count of QUIC connections freed after timing out |
789795
| <span class="metrics-name">send_&#8203;connections_&#8203;retried</span> | counter | Total count of QUIC connections retried |
790796
| <span class="metrics-name">send_&#8203;connection_&#8203;error_&#8203;no_&#8203;slots</span> | counter | Total count of connection errors due to no slots |
791797
| <span class="metrics-name">send_&#8203;connection_&#8203;error_&#8203;retry_&#8203;fail</span> | counter | Total count of connection retry failures |

src/disco/metrics/generated/fd_metrics_enums.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
#define FD_METRICS_ENUM_QUIC_ENC_LEVEL_V_APP_NAME "app"
147147

148148
#define FD_METRICS_ENUM_QUIC_CONN_STATE_NAME "quic_conn_state"
149-
#define FD_METRICS_ENUM_QUIC_CONN_STATE_CNT (8UL)
149+
#define FD_METRICS_ENUM_QUIC_CONN_STATE_CNT (9UL)
150150
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_INVALID_IDX 0
151151
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_INVALID_NAME "invalid"
152152
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_HANDSHAKE_IDX 1
@@ -163,6 +163,8 @@
163163
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_CLOSE_PENDING_NAME "close_pending"
164164
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_DEAD_IDX 7
165165
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_DEAD_NAME "dead"
166+
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_TIMEOUT_IDX 8
167+
#define FD_METRICS_ENUM_QUIC_CONN_STATE_V_TIMEOUT_NAME "timeout"
166168

167169
#define FD_METRICS_ENUM_NEW_CONTACT_OUTCOME_NAME "new_contact_outcome"
168170
#define FD_METRICS_ENUM_NEW_CONTACT_OUTCOME_CNT (5UL)

src/disco/metrics/generated/fd_metrics_quic.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,13 @@ const fd_metrics_meta_t FD_METRICS_QUIC[FD_METRICS_QUIC_TOTAL] = {
2929
DECLARE_METRIC_ENUM( QUIC_CONNECTIONS_STATE, GAUGE, QUIC_CONN_STATE, ABORT ),
3030
DECLARE_METRIC_ENUM( QUIC_CONNECTIONS_STATE, GAUGE, QUIC_CONN_STATE, CLOSE_PENDING ),
3131
DECLARE_METRIC_ENUM( QUIC_CONNECTIONS_STATE, GAUGE, QUIC_CONN_STATE, DEAD ),
32+
DECLARE_METRIC_ENUM( QUIC_CONNECTIONS_STATE, GAUGE, QUIC_CONN_STATE, TIMEOUT ),
3233
DECLARE_METRIC( QUIC_CONNECTIONS_CREATED, COUNTER ),
3334
DECLARE_METRIC( QUIC_CONNECTIONS_CLOSED, COUNTER ),
3435
DECLARE_METRIC( QUIC_CONNECTIONS_ABORTED, COUNTER ),
3536
DECLARE_METRIC( QUIC_CONNECTIONS_TIMED_OUT, COUNTER ),
37+
DECLARE_METRIC( QUIC_CONNECTIONS_TIMEOUT_REVIVED, COUNTER ),
38+
DECLARE_METRIC( QUIC_CONNECTIONS_TIMEOUT_FREED, COUNTER ),
3639
DECLARE_METRIC( QUIC_CONNECTIONS_RETRIED, COUNTER ),
3740
DECLARE_METRIC( QUIC_CONNECTION_ERROR_NO_SLOTS, COUNTER ),
3841
DECLARE_METRIC( QUIC_CONNECTION_ERROR_RETRY_FAIL, COUNTER ),

0 commit comments

Comments
 (0)