Fix CodeQL lints

Author: riptl

src/app/firedancer-dev/commands/repair.c

@@ -377,7 +377,7 @@ repair_cmd_args( int *    pargc,
 }
 
 static void
-repair_cmd_fn( args_t *   args FD_PARAM_UNUSED,
+repair_cmd_fn( args_t *   args,
                config_t * config ) {
 
   FD_LOG_NOTICE(( "Repair profiler topo" ));

src/discof/backtest/fd_backtest_tile.c

@@ -344,8 +344,8 @@ query_mr( fd_shred_t const * shred ) {
 static void
 after_credit_rocksdb( ctx_t *             ctx,
                       fd_stem_context_t * stem,
-                      int * opt_poll_in   FD_PARAM_UNUSED,
-                      int * charge_busy   FD_PARAM_UNUSED ) {
+                      int *               opt_poll_in FD_PARAM_UNUSED,
+                      int *               charge_busy ) {
 
   if( FD_UNLIKELY( !ctx->playback_started ) ) {
     ulong wmark = fd_fseq_query( ctx->published_wmark );

src/discof/poh/fd_poh_tile.c

@@ -1796,7 +1796,6 @@ during_frag( fd_poh_ctx_t * ctx,
              ulong          chunk,
              ulong          sz,
              ulong          ctl FD_PARAM_UNUSED ) {
-  (void)sig;
   ctx->skip_frag = 0;
 
   if( FD_UNLIKELY( ctx->in_kind[ in_idx ]==IN_KIND_STAKE ) ) {

src/discof/repair/fd_repair_tile.c

@@ -642,7 +642,7 @@ after_frag( fd_repair_tile_ctx_t * ctx,
 static inline void
 after_credit( fd_repair_tile_ctx_t * ctx,
               fd_stem_context_t *    stem,
-              int *                  opt_poll_in FD_PARAM_UNUSED,
+              int *                  opt_poll_in,
               int *                  charge_busy ) {
 
   if( FD_LIKELY( !fd_fec_out_empty( ctx->fec_chainer->out ) && ctx->store ) ) {

src/discof/restore/fd_snapdc_tile.c

@@ -247,7 +247,6 @@ returnable_frag( fd_snapdc_tile_t *  ctx,
                  fd_stem_context_t * stem ) {
   (void)in_idx;
   (void)seq;
-  (void)sig;
   (void)tsorig;
   (void)tspub;
 

src/discof/restore/fd_snapin_tile.c

@@ -280,7 +280,6 @@ returnable_frag( fd_snapin_tile_t *  ctx,
                  fd_stem_context_t * stem ) {
   (void)in_idx;
   (void)seq;
-  (void)sig;
   (void)tsorig;
   (void)tspub;
 

src/discof/restore/fd_snaprd_tile.c

@@ -338,7 +338,6 @@ after_credit( fd_snaprd_tile_t *  ctx,
               fd_stem_context_t * stem,
               int *               opt_poll_in,
               int *               charge_busy ) {
-  (void)stem;
   (void)opt_poll_in;
   (void)charge_busy;
 

src/discof/shredcap/fd_shredcap_tile.c

@@ -398,7 +398,7 @@ during_frag( fd_capture_tile_ctx_t * ctx,
 
 static void
 after_credit( fd_capture_tile_ctx_t * ctx,
-              fd_stem_context_t *     stem FD_PARAM_UNUSED,
+              fd_stem_context_t *     stem,
               int *                   opt_poll_in FD_PARAM_UNUSED,
               int *                   charge_busy FD_PARAM_UNUSED ) {
 

src/waltz/ip/fd_fib4.c

@@ -166,8 +166,8 @@ fd_fib4_hmap_insert( fd_fib4_t *     fib,
   fd_fib4_hmap_entry_t * ele = fd_fib4_hmap_query_ele( query );
   ele->dst_addr              = ip4_dst;
   FD_TEST( hop );
-  fd_memcpy( &ele->next_hop, hop, sizeof(fd_fib4_hop_t) );
-  fib->hmap_cnt              += 1;
+  ele->next_hop = *hop;
+  fib->hmap_cnt++;
 
   fd_fib4_hmap_publish( query );
 
@@ -214,7 +214,7 @@ fd_fib4_insert( fd_fib4_t *     fib,
   FD_COMPILER_MFENCE();
 
   FD_TEST( hop );
-  fd_memcpy( entry, hop, sizeof(fd_fib4_hop_t) );
+  *entry = *hop;
 
   return 1;
 }
@@ -244,7 +244,7 @@ fd_fib4_lookup( fd_fib4_t const * fib,
       if( FD_UNLIKELY( find_err ) ) {
         return &fd_fib4_hop_blackhole;
       }
-      fd_memcpy( out, &next_hop, sizeof( fd_fib4_hop_t ) );
+      *out = next_hop;
       return out;
     } else if( FD_UNLIKELY( find_err!=FD_MAP_ERR_KEY ) ) {
       return &fd_fib4_hop_blackhole;