Generic userland RX flow steering #5993
Open
+533
−559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
changed the title
ripatel-fd
force-pushed
the
ripatel/net-rx-flow-steer
branch
5 times, most recently
from
1d08e82 to
57ee3fd
Compare
ripatel-fd
force-pushed
the
ripatel/net-rx-flow-steer
branch
3 times, most recently
from
71ce825 to
6ad8e44
Compare
ripatel-fd
requested review from
lidatong,
emwang-jump,
ptaffet-jump and
mmcgee-jump
as code owners
ripatel-fd
force-pushed
the
ripatel/net-rx-flow-steer
branch
from
6ad8e44 to
979f1f5
Compare
ripatel-fd
force-pushed
the
ripatel/net-rx-flow-steer
branch
from
979f1f5 to
9a69458
Compare
lidatong
reviewed
Aug 14, 2025
ripatel-fd
force-pushed
the
ripatel/net-rx-flow-steer
branch
from
9a69458 to
d6e7e50
Compare
Fixes a design flaw where the xdp and sock tiles hardcode the flow steering rules for the app tiles. Defines a generic 'topo_net_rx' struct that maps UDP ports to output links (and metadata like DST_PROTO IDs). Adds a 'find_16x16' API for AVX-accelerated fast port matching. Temporarily undoes the 'repair ping-pong' flow steering hack.
Forwards ping frames arriving at the 'repair ingress' port from the shred tile to the repair tile. This was previously done at the net tile level, but is moved to the shred/repair tiles to keep the network stack clean.
ripatel-fd
force-pushed
the
ripatel/net-rx-flow-steer
branch
from
d6e7e50 to
31f5fde
Compare
mmcgee-jump
reviewed
Aug 15, 2025
| typedef struct fd_topo_net_rx fd_topo_net_rx_t; | ||
|
|
||
| static inline void | ||
| fd_topo_net_rx_rule_push( fd_topo_net_rx_t * net, |
There was a problem hiding this comment.
I don't love this in fd_topo.h. Couldn't this go in fd_topob ?
mmcgee-jump
reviewed
Aug 15, 2025
|
|
||
| ulong link_name_len = strnlen( link_name, FD_TOPO_LINK_NAME_SZ ); | ||
| if( FD_UNLIKELY( link_name_len>=FD_TOPO_LINK_NAME_SZ ) ) { | ||
| FD_LOG_ERR(( "link name too long: \"%s\"", link_name )); |
There was a problem hiding this comment.
These kind of checks should go in validate function
mmcgee-jump
reviewed
Aug 15, 2025
| #endif | ||
| if( FD_UNLIKELY( port_idx >= ctx->rx_port_cnt ) ) { | ||
| /* Dump out the listen port configuration to aid debugging */ | ||
| FD_LOG_NOTICE(( "Fatal error occurred.\nDumping XDP RX UDP port configuration to aid debugging:" )); |
There was a problem hiding this comment.
Probably log this at WARNING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused SIOCGIFHWADDR call.
Fixes a design flaw where the xdp and sock tiles hardcode the
flow steering rules for the app tiles.
Defines a generic 'topo_net_rx' struct that maps UDP ports to
output links (and metadata like DST_PROTO IDs).
Adds a 'find_16x16' API for AVX-accelerated fast port matching.
Move repair forwarding logic from net/sock tiles to repair/shred.