solcap: v2 #7337

nipatel-jump · 2025-11-19T20:24:41Z

No description provided.

ibhatt-jumptrading

nits so far

src/disco/topo/fd_topo.h

src/discof/capture/fd_capture_ctx.c

src/discof/capture/fd_capture_tile.c

ibhatt-jumptrading · 2025-11-20T00:02:21Z

src/discof/capture/fd_capture_tile.c

+      }
+    default:
+    /* Unknown signal received in message processing */
+      FD_LOG_ERR(( "Unknown signal received in message processing: sig=%lu", (unsigned long)msg_hdr->sig ));


src/discof/capture/fd_capture_tile.c

ibhatt-jumptrading · 2025-11-20T00:05:54Z

src/discof/capture/fd_capture_tile.c

+    // FD_LOG_WARNING(("SOM: in_idx=%lu sig=%u->%u eom=%d", in_idx, msg_hdr->sig, ctx->msg_set_sig, eom));
+    /* Handle file rotation for recent_only mode */
+    if( ctx->recent_only ) {
+      if( ctx->recent_file_start_slot == ULONG_MAX )


use brackets for this if statement.

i would also do if( !ctx->recent_only ) return; instead of nesthing this big code block

src/discof/capture/fd_capture_tile.c

src/discof/exec/fd_exec_tile.c

src/flamenco/capture/fd_solcap_writer.h

src/flamenco/capture/fd_solcap_writer.c

github-actions · 2025-11-20T02:47:40Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.073573 s`	`0.073661 s`	`0.120%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3.254 s`	`4.417 s`	`35.741%` ⚠️
backtest `mainnet-368528500-perf` total elapsed	`73.572714 s`	`73.660847 s`	`0.120%` ✅
`firedancer mem` usage with `mainnet.toml`	`1001.1 GiB`	`989.1 GiB`	`-1.199%` ✅

github-actions · 2025-11-20T06:40:54Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.073606 s`	`0.073607 s`	`0.001%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3.288 s`	`3.179 s`	`-3.315%` ✅
backtest `mainnet-368528500-perf` total elapsed	`73.606362 s`	`73.606635 s`	`0.000%` ✅
`firedancer mem` usage with `mainnet.toml`	`1001.1 GiB`	`989.1 GiB`	`-1.199%` ✅

github-actions · 2025-11-20T16:06:02Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.0568 s`	`0.051004 s`	`-10.204%` ✅
backtest `mainnet-368528500-perf` snapshot load	`2.63 s`	`1.661 s`	`-36.844%` ✅
backtest `mainnet-368528500-perf` total elapsed	`56.800083 s`	`51.004463 s`	`-10.204%` ✅
`firedancer mem` usage with `mainnet.toml`	`1001.1 GiB`	`989.1 GiB`	`-1.199%` ✅

github-actions · 2025-11-20T16:13:37Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.076865 s`	`0.076953 s`	`0.114%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3.122 s`	`3.04 s`	`-2.627%` ✅
backtest `mainnet-368528500-perf` total elapsed	`76.864597 s`	`76.952613 s`	`0.115%` ✅
`firedancer mem` usage with `mainnet.toml`	`1001.1 GiB`	`989.1 GiB`	`-1.199%` ✅

github-actions · 2025-11-20T23:11:00Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.073707 s`	`0.073703 s`	`-0.005%` ✅
backtest `mainnet-368528500-perf` snapshot load	`3.217 s`	`3.166 s`	`-1.585%` ✅
backtest `mainnet-368528500-perf` total elapsed	`73.707431 s`	`73.703413 s`	`-0.005%` ✅
`firedancer mem` usage with `mainnet.toml`	`1001.1 GiB`	`989.1 GiB`	`-1.199%` ✅

ripatel-fd · 2025-11-21T15:32:31Z

.github/workflows/tests.yml

-        run: |
-          sudo prlimit --pid $$ --memlock=-1:-1
-          source /opt/${{ matrix.compiler }}/${{ matrix.compiler }}-${{ matrix.compiler-version }}/activate
-          DUMP=../dump make run-solcap-tests


These tests ensured that the solcap infra itself works. Let's make sure we keep an integration test

ripatel-fd · 2025-11-21T15:33:04Z

src/discof/capture/fd_capture_ctx.h

+
+Nishk (TODO): Write more docs for capture context
+
+*/


Let's resolve this todo before merging

ripatel-fd · 2025-11-21T15:33:20Z

src/discof/capture/fd_capture_ctx.h

+#include "../../flamenco/fd_rwlock.h"
+#include "../../util/fd_util_base.h"
+#include "../../util/log/fd_log.h"
+#include <sys/types.h>


unused import

ripatel-fd · 2025-11-21T15:33:34Z

src/discof/capture/fd_capture_ctx.h

+struct fd_capture_link {
+  const fd_capture_link_vt_t * vt;
+};
+typedef struct fd_capture_link fd_capture_link_t;


Can you add a brief comment to each of these types explaining what it does

ripatel-fd · 2025-11-21T15:33:43Z

src/discof/capture/fd_capture_ctx.h

+typedef struct fd_capture_link_vt fd_capture_link_vt_t;
+
+struct fd_capture_link {
+  const fd_capture_link_vt_t * vt;


Suggested change

const fd_capture_link_vt_t * vt;

fd_capture_link_vt_t const * vt;

ripatel-fd · 2025-11-21T15:34:10Z

src/discof/capture/fd_capture_ctx.h

+  fd_pubkey_t              pubkey;
+  fd_solana_account_meta_t info;
+  ulong                    data_sz;
+  fd_hash_t                hash;


Document what type of hash is this. (First 32 bytes of the lthash?)

ripatel-fd · 2025-11-21T15:45:09Z

src/discof/capture/fd_capture_tile.c

+
+
+  /* If we're processing a message from a different input, skip this
+     fragment */


Would we not want to repeat this fragment instead of skipping it?

ripatel-fd · 2025-11-21T15:46:04Z

src/discof/capture/fd_capture_tile.c

+  if( som ) {
+    msg_hdr           = fd_type_pun( (void *)data );
+    actual_data       = (char *)(data + sizeof(fd_solcap_buf_msg_t));
+    actual_data_sz    = sz - sizeof(fd_solcap_buf_msg_t);


missing bounds check, sz can be zero and this can underflow

ripatel-fd · 2025-11-21T15:46:33Z

src/discof/capture/fd_capture_tile.c

+        */
+        FD_TEST( fsync( ctx->fd ) == 0 );
+        FD_TEST( fsync( next_fd ) == 0 );
+        FD_TEST( ftruncate( next_fd, 0L ) == 0 );


I don't think fsync is necessary here. ftruncate operates on page cache, like write. fsync doesn't change the file content from a VFS point of view. It just cleans write caches

ripatel-fd · 2025-11-21T15:47:12Z

src/discof/capture/fd_capture_tile.c

+
+    if (ctx->msg_set_sig == SOLCAP_WRITE_BANK_PREIMAGE) {
+      FD_TEST( fsync(ctx->fd) == 0 );
+    }


remove fsync

ripatel-fd · 2025-11-21T15:48:40Z

src/discof/capture/fd_capture_tile.c

+#include "../../disco/stem/fd_stem.c"
+
+fd_topo_run_tile_t fd_tile_capture = {
+  .name                     = "captur",


I'd call it "solcap" tile since that's the name of the project

ripatel-fd · 2025-11-21T15:49:53Z

src/discof/capture/fd_capture_ctx.c

+#include "../../tango/fd_tango_base.h"
+#include "../../tango/fseq/fd_fseq.h"
+
+#include <time.h>


unused import?

ripatel-fd · 2025-11-21T15:50:31Z

src/discof/capture/fd_capture_ctx.c

+}
+
+static uint
+valid_slot_range(fd_capture_ctx_t * ctx, ulong slot) {


Suggested change

valid_slot_range(fd_capture_ctx_t * ctx, ulong slot) {

valid_slot_range( fd_capture_ctx_t * ctx,

ulong slot ) {

ripatel-fd · 2025-11-21T15:53:00Z

src/discof/capture/fd_capture_ctx.h

I'm not a fan of the idea of a capture context. It conflates two separate things - The creation of solfuzz test inputs (protosol Protobufs) and solcaps. Let's just have a src/discof/solcap module and then separate logic for creating Protobufs in src/flamenco/runtime/tests

ripatel-fd · 2025-11-21T15:53:48Z

src/discof/replay/fd_exec.h

+
+  /* Used currently by solcap to maintain ordering of messages
+     this is a hack for v2.0, will change to using txn sigs eventually */
+  ulong      capture_txn_idx;


Why do you consider this a hack? I don't think there's anything wrong with letting the replay sequence transactions for internal identification.

ripatel-fd · 2025-11-21T15:54:12Z

src/discof/replay/fd_replay_tile.c

-  fd_capture_ctx_t * capture_ctx;
-  FILE *             capture_file;
+  fd_capture_ctx_t *     capture_ctx;
+  FILE *                 capture_file;


Why does the replay tile still hold on to a file handle if the writing logic has been moved to the solcap tile?

ripatel-fd · 2025-11-21T15:54:51Z

src/discof/replay/fd_replay_tile.c

      memcpy( &exec_msg->txn, txn_p, sizeof(fd_txn_p_t) );
      exec_msg->bank_idx = task->txn_exec->bank_idx;
      exec_msg->txn_idx  = task->txn_exec->txn_idx;
+      if ( FD_UNLIKELY( ctx->capture_ctx ) ) {


Suggested change

if ( FD_UNLIKELY( ctx->capture_ctx ) ) {

if( FD_UNLIKELY( ctx->capture_ctx ) ) {

ripatel-fd · 2025-11-21T15:55:12Z

src/discof/replay/fd_replay_tile.c

+    ulong consumer_tile_idx = fd_topo_find_tile( topo, "captur", 0UL );
+    fd_topo_tile_t * consumer_tile = &topo->tiles[ consumer_tile_idx ];
+    cap_repl_out->fseq = NULL;
+    for (ulong j = 0UL; j < consumer_tile->in_cnt; j++ ) {


Suggested change

for (ulong j = 0UL; j < consumer_tile->in_cnt; j++ ) {

for( ulong j = 0UL; j < consumer_tile->in_cnt; j++ ) {

ripatel-fd · 2025-11-21T15:55:23Z

src/flamenco/capture/fd_solcap_proto.h

+#include <stdlib.h>
+#include <stdbool.h>
+
+#include <bits/stdint-uintn.h>


random import, remove

Please configure your editor to not do auto imports, most of them in this PR are wrong

ripatel-fd · 2025-11-21T15:56:30Z

src/flamenco/capture/fd_solcap_import.c

https://github.com/firedancer-io/solcap-tools this repo is still empty, therefore we cannot yet remove production debugging tooling. Please revert deletion. Let's add it back when solcap-tools is promoted to stable

ripatel-fd · 2025-11-21T15:57:44Z

src/flamenco/capture/fd_solcap_proto.h

-  /* 0x10 */ uint meta_sz;
-  /* 0x14 */ uint _pad14[3];
+   .solcap is a portable file format for capturing Solana runtime data
+   suitable for replay and debugging. It is laid out below:


solcap is not a file format. This is just a pcapng file capturing solcap packets.
Important to make this distinction so it's clear to the reader that this format will work with existing tools like Wireshark.

ripatel-fd · 2025-11-21T15:58:01Z

src/flamenco/capture/fd_solcap_proto.h

+      -- ...
+
+   The solcap format is compatible with the pcapng format, allowing for
+   easy interoperability with existing tools that support pcapng. The


It is not only compatible, it is pcapng format

ripatel-fd · 2025-11-21T15:59:23Z

src/flamenco/capture/fd_solcap_proto.h

+   Enhanced Packet Block (EPB) - A single solcap message.
+   The internal chunk header contains additional metadata about the
+   message, used for identifying the message and its position in the
+   stream.


These are redundant to declare. I would just point to the pcapng spec for the definitions of SHB, IDB, and EPB.

And then briefly mention any restrictions such as:
The IDB uses DLT_USER0 (specify the Ethertype that solcap uses).
EPB is always used.
Max packet size

ripatel-fd · 2025-11-21T15:59:27Z

src/flamenco/capture/fd_solcap_proto.h

+      - Account Updates
+      - Bank Preimages
+
+   The dumping of the exectuion can be done in multiple ways:


ripatel-fd · 2025-11-21T16:01:45Z

src/flamenco/capture/fd_solcap_proto.h

+      header allows for the reader to process the message in the correct
+      encoding scheme. Currently the list of messages is:
+      - Account Updates
+      - Bank Preimages


This is the most important part of the protocol specification. And should be moved to a separate Markdown specification file. This should specify:

What are solcap packets / what problems do they solve (brief intro part)

The conceptual solcap layers (the base layer would probably be a muxing layer that identifies different solcap sub-types)

Every packet format documented as a C struct

Every enum (such as different solcap packet types)

This work should be done since solcap aims to be a portable / generic format for structured tracing of Solana validator events. Therefore, the source of truth should be in a specification file, not in the Firedancer code

ripatel-fd · 2025-11-21T16:02:34Z

src/flamenco/capture/fd_solcap_proto.h

+    [SOLCAP_WRITE_BANK_PREIMAGE] = SOLCAP_WRITE_BANK_PREIMAGE, \
+    [SOLCAP_WRITE_STAKE_REWARD_EVENT] = SOLCAP_WRITE_STAKE_REWARD_EVENT, \
+    [SOLCAP_WRITE_VOTE_ACCOUNT_PAYOUT] = SOLCAP_WRITE_VOTE_ACCOUNT_PAYOUT, \
+})[x])


I kind of see what this is trying to do, but why not just make this a static ushort const[] = { ... } instead of a define?

ripatel-fd · 2025-11-21T16:03:09Z

src/flamenco/capture/fd_solcap_proto.h

-  /* 0x20 */ long  acc_coff;  /* chunk offset to account chunk */
-  /* 0x28 */ ulong _pad28[5];
-  /* 0x50 */
+typedef struct fd_solcap_chunk_idb_hdr fd_solcap_chunk_idb_hdr_t;


To separate layers cleanly, pcapng structs should not be defined in the solcap protocol layer (since pcap is a layer below). Use src/util/net/pcapng instead

ripatel-fd · 2025-11-21T16:03:22Z

src/flamenco/capture/fd_solcap_proto.h

+   /* 0x18 */ uint32_t original_packet_len; /* original packet length */
+   /* 0x1c */ /* packet data follows immediately after this structure */
 };
+typedef struct fd_solcap_chunk_epb_hdr fd_solcap_chunk_epb_hdr_t;


same here, remove EPB and reuse pcapng header

ripatel-fd · 2025-11-21T16:03:34Z

src/flamenco/capture/fd_solcap_proto.h

+struct __attribute__((packed)) fd_solcap_chunk_ftr {
+   /* int_hdr + packet_len */ uint32_t block_len_redundant; /* length of the block */
+};
+typedef struct fd_solcap_chunk_ftr fd_solcap_chunk_ftr_t;


remove this and reuse pcapng

ripatel-fd · 2025-11-21T16:03:57Z

src/flamenco/capture/fd_solcap_proto.h

+   fd_pubkey_t stake_acc_addr;
+   fd_pubkey_t vote_acc_addr;
+   uint        commission;
+   long        vote_rewards;


hidden padding

ripatel-fd · 2025-11-21T16:04:04Z

src/flamenco/capture/fd_solcap_proto.h

+   ulong   payout_epoch;
+   ulong   reward_epoch;
+   ulong   inflation_lamports;
+   uint128 total_points;


hidden padding

This is not portable btw, uint128 has different alignments on different arches (8 vs 16 bytes)

ripatel-fd · 2025-11-21T16:05:52Z

src/flamenco/capture/fd_solcap_writer.c

-    if( FD_UNLIKELY( err!=0 ) ) return err;   \
-  } while(0)
-
+#include <time.h>


why time.h?

ripatel-fd · 2025-11-21T16:07:35Z

src/flamenco/capture/fd_solcap_writer.c

-    FD_LOG_WARNING(( "fseek failed (%d-%s)", errno, strerror( errno ) ));
-    return NULL;
-  }
+  FD_TEST(sizeof(fd_solcap_chunk_idb_hdr_t) == write(fd, &idb_hdr, sizeof(fd_solcap_chunk_idb_hdr_t)));


(This is completely fine but would just like to point out to avoid confusion:)
While the protocol specification (in headers) should be cleanly separated out in layers, it's fine to mix all the layers in the writer class for efficiency. It's just important that the definitions themselves are separate if we ever do live streaming (e.g. over InfiniBand) or graduate from pcapng to a more heavy duty data format (like Parquet or whatever). Keeping the transport/container and data layers separate helps with that.

ripatel-fd · 2025-11-21T16:07:54Z

src/flamenco/capture/fd_solcap_writer.c

-  if( FD_UNLIKELY( !pb_encode( &stream, desc, msg ) ) ) {
-    FD_LOG_WARNING(( "pb_encode failed (%s)", PB_GET_ERROR(&stream) ));
-    return EPROTO;
+  if (padding_needed > 0) {


Suggested change

if (padding_needed > 0) {

if( padding_needed > 0 ) {

formatting bugs

ripatel-fd · 2025-11-21T16:08:13Z

src/flamenco/capture/fd_solcap_writer.c

-    return EPROTO;
+  if (padding_needed > 0) {
+    static const char zeros[4] = {0};
+    FD_TEST(padding_needed == write(fd, zeros, padding_needed));


Doing a syscall to write 4 padding bytes seems very inefficient, consider the use of fd_io_buffered

ripatel-fd · 2025-11-21T16:08:29Z

src/flamenco/capture/fd_solcap_writer.h

-typedef struct fd_solcap_writer fd_solcap_writer_t;
+/* fd_solcap_writer_t is a writer utility for solcap files.
+
+    Each soclap write function is responsible for encoding and writing


Suggested change

Each soclap write function is responsible for encoding and writing

Each solcap write function is responsible for encoding and writing

ripatel-fd · 2025-11-21T16:08:45Z

src/flamenco/capture/fd_solcap_writer.h


-struct fd_solcap_writer;
-typedef struct fd_solcap_writer fd_solcap_writer_t;
+/* fd_solcap_writer_t is a writer utility for solcap files.


Suggested change

/* fd_solcap_writer_t is a writer utility for solcap files.

/* fd_solcap_writer_t produces pcapng dumps containing solcap packets.

ripatel-fd · 2025-11-21T16:09:09Z

src/flamenco/capture/fd_solcap_writer.h

+typedef struct fd_solcap_writer {
+  int   fd;
+  ulong stream_goff;
+} fd_solcap_writer_t;


separate struct definition and type def

ripatel-fd · 2025-11-21T16:09:44Z

src/flamenco/capture/fd_solcap_writer.h

-   fd_solcap_writer_footprint returns a non-zero byte count. */
+typedef struct fd_solcap_writer {
+  int   fd;
+  ulong stream_goff;


"goff" (global offset) was a solcap v1 thing, I think we can remove this entirely and use the file descriptor's internal offset?

ripatel-fd · 2025-11-21T16:10:42Z

src/flamenco/capture/fd_solcap_writer_stub.c

The stub was quite useful to retain portability for executing the runtime on a non-hosted target, like an embedded device. But I don't insist on keeping it.

ripatel-fd · 2025-11-21T16:11:27Z

src/flamenco/rewards/fd_rewards.c

-        epoch,
-        epoch-1UL, /* FIXME: this is not strictly correct */
-        *rewards_out,
-        (fd_w_u128_t){ .ud=points } );


Solcap v2 should only be merged when it's at feature parity with solcap v1, if solcap v1 is being simultaneously removed.

ripatel-fd · 2025-11-21T16:12:25Z

src/flamenco/runtime/tests/fd_sol_compat.c

-    runner->solcap_file = fopen( solcap_path, "w" );
-    if( FD_UNLIKELY( !runner->solcap_file ) ) {
-      FD_LOG_ERR(( "fopen($FD_SOLCAP=%s) failed (%i-%s)", solcap_path, errno, fd_io_strerror( errno ) ));
+    int fd = open( solcap_path, O_WRONLY | O_CREAT | O_TRUNC, 0644 );


use of file descriptor I/O directly is less efficient than using libc FILE or fd_io_buffered due to lack of buffering / more frequent syscalls

ripatel-fd · 2025-11-21T16:13:16Z

src/flamenco/runtime/tests/Local.mk

-$(call make-unit-test,test_sol_compat,test_sol_compat,fd_flamenco_test fd_flamenco fd_tango fd_funk fd_ballet fd_util fd_disco,$(SECP256K1_LIBS) $(FLATCC_LIBS))
-$(call make-shared,libfd_exec_sol_compat.so,fd_sol_compat,fd_flamenco_test fd_flamenco fd_funk fd_ballet fd_util fd_disco,$(SECP256K1_LIBS) $(FLATCC_LIBS) $(SOL_COMPAT_FLAGS))
+$(call make-unit-test,test_sol_compat,test_sol_compat,fd_flamenco_test fd_flamenco fd_tango fd_funk fd_ballet fd_util fd_disco fd_discof,$(SECP256K1_LIBS) $(FLATCC_LIBS))
+$(call make-shared,libfd_exec_sol_compat.so,fd_sol_compat,fd_flamenco_test fd_flamenco fd_funk fd_ballet fd_util fd_disco fd_discof,$(SECP256K1_LIBS) $(FLATCC_LIBS) $(SOL_COMPAT_FLAGS))


This is a layering violation / circular dependency. discof (runtime tiles) is layered on top of flamenco (Firedancer SVM). The SVM should not depend on prod tile code

ripatel-fd · 2025-11-21T16:17:19Z

src/flamenco/types/fd_types.h

 struct __attribute__((packed)) fd_solana_account_meta {
  ulong lamports;
-  ulong rent_epoch;
  uchar owner[32];


Remove solana_account_meta and solana_account_hdr from types.json entirely and just make them part of solcap

nipatel-jump force-pushed the nishk/solcap_window branch 2 times, most recently from 765f7f5 to a155373 Compare November 19, 2025 21:03

ibhatt-jumptrading reviewed Nov 20, 2025

View reviewed changes

nipatel-jump force-pushed the nishk/solcap_window branch from a155373 to 912bd0f Compare November 20, 2025 02:42

nipatel-jump force-pushed the nishk/solcap_window branch from 912bd0f to 9069270 Compare November 20, 2025 06:36

nipatel-jump force-pushed the nishk/solcap_window branch from 9069270 to a858a49 Compare November 20, 2025 16:02

nipatel-jump force-pushed the nishk/solcap_window branch from a858a49 to 5eb62c9 Compare November 20, 2025 16:08

nipatel-jump force-pushed the nishk/solcap_window branch from 5eb62c9 to eaa62ba Compare November 20, 2025 16:52

solcap: v2

3574184

nipatel-jump force-pushed the nishk/solcap_window branch from eaa62ba to 3574184 Compare November 20, 2025 17:03

kbhargava-jump force-pushed the nishk/solcap_window branch 3 times, most recently from be74c85 to 9d70540 Compare November 20, 2025 23:05

kbhargava-jump requested a review from ripatel-fd as a code owner November 20, 2025 23:05

ripatel-fd reviewed Nov 21, 2025

View reviewed changes

ripatel-fd requested changes Nov 21, 2025

View reviewed changes

ripatel-fd reviewed Nov 21, 2025

View reviewed changes

src/flamenco/capture/fd_solcap_writer.c

if( FD_UNLIKELY( err!=0 ) ) return err; \

} while(0)

#include <time.h>

Copy link

Contributor

ripatel-fd Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why time.h?

ripatel-fd reviewed Nov 21, 2025

View reviewed changes

fix build

8065fae

kbhargava-jump force-pushed the nishk/solcap_window branch from 9d70540 to 8065fae Compare November 21, 2025 21:27

	const fd_capture_link_vt_t * vt;
	fd_capture_link_vt_t const * vt;



		/* If we're processing a message from a different input, skip this
		fragment */

	valid_slot_range(fd_capture_ctx_t * ctx, ulong slot) {
	valid_slot_range( fd_capture_ctx_t * ctx,
	ulong slot ) {

	if ( FD_UNLIKELY( ctx->capture_ctx ) ) {
	if( FD_UNLIKELY( ctx->capture_ctx ) ) {

	for (ulong j = 0UL; j < consumer_tile->in_cnt; j++ ) {
	for( ulong j = 0UL; j < consumer_tile->in_cnt; j++ ) {

	Each soclap write function is responsible for encoding and writing
	Each solcap write function is responsible for encoding and writing

	/* fd_solcap_writer_t is a writer utility for solcap files.
	/* fd_solcap_writer_t produces pcapng dumps containing solcap packets.

solcap: v2 #7337

Are you sure you want to change the base?

solcap: v2 #7337

Uh oh!

Conversation

nipatel-jump commented Nov 19, 2025

Uh oh!

ibhatt-jumptrading left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025

Performance Measurements ⏳

Uh oh!

github-actions bot commented Nov 20, 2025

Performance Measurements ⏳

Uh oh!

github-actions bot commented Nov 20, 2025

Performance Measurements ⏳

Uh oh!

github-actions bot commented Nov 20, 2025

Performance Measurements ⏳

Uh oh!

github-actions bot commented Nov 20, 2025

Performance Measurements ⏳

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment