runtime: clean up block harness init #7361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all lock guards into their own scopes to defend against lock leaks - Reject input instead of crashing if sysvars are missing
Performance Measurements ⏳
|
mjain-jump
reviewed
Nov 20, 2025
Comment on lines
+376
to
+379
| if( FD_UNLIKELY( !epoch_schedule ) ) { | ||
| FD_LOG_WARNING(( "Block test vector missing epoch_schedule sysvar" )); | ||
| return NULL; | ||
| } |
Contributor
There was a problem hiding this comment.
i actually prefer crashing here because otherwise small mutator changes that alter this behavior go unnoticed
mjain-jump
requested changes
Nov 20, 2025
Contributor
mjain-jump
left a comment
mjain-jump
left a comment
There was a problem hiding this comment.
scoping looks good, but dont agree with the silent input rejection
Contributor
Author
|
@mjain-jump there is no silent input rejection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lock leaks