flamenco: clean up instr info + trace #7451
Open
+149
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjain-jump
force-pushed
the
mjain/clean-up-instr-info
branch
from
fb4891b to
f957e6d
Compare
mjain-jump
force-pushed
the
mjain/clean-up-instr-info
branch
2 times, most recently
from
de716f8 to
e6d03b1
Compare
mjain-jump
commented
Nov 27, 2025
Comment on lines
+127
to
+129
| if( FD_UNLIKELY( test_ctx->data->size>FD_TXN_MTU ) ) { | ||
| FD_LOG_ERR(( "invariant violation: instr data sz is too large %u > %lu", test_ctx->data->size, FD_TXN_MTU )); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
there were 74 fixtures that violated this condition which were regenerated (commit sha is updated in this PR). solfuzz also fixes up the instr data sz already, so no changes are needed there
mjain-jump
force-pushed
the
mjain/clean-up-instr-info
branch
2 times, most recently
from
17ae921 to
5093261
Compare
mjain-jump
requested review from
0x0ece,
alpeng-jump,
anwayde,
jherrera-jump,
mmcgee-jump and
ptaffet-jump
as code owners
mjain-jump
force-pushed
the
mjain/clean-up-instr-info
branch
from
5093261 to
1f73a2a
Compare
Performance Measurements ⏳
|
mjain-jump
force-pushed
the
mjain/clean-up-instr-info
branch
from
1f73a2a to
3b183d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/firedancer-io/auditor-internal/issues/341 https://github.com/firedancer-io/auditor-internal/issues/342