Add check to CI to make sure that changes to auto-generated files are committed

Also remove the unconventional image caching behaviour from team.ini
because the URL is only accessed once.

Author: connorjward

.github/workflows/core.yml

@@ -392,6 +392,22 @@ jobs:
         if: success() || steps.upload_docs.conclusion == 'success'
         run: echo "conclusion=success" >> "$GITHUB_OUTPUT"
 
+      # Some files are automatically generated when we install or build the
+      # docs (e.g. CITATION.rst). These files are committed to the repository
+      # so uncommitted changes at this point reflect changes in the automatically
+      # generated files that ought to be committed.
+      - name: Check no untracked files
+        run: |
+          cd firedrake-repo
+          if [ -z "$( git status --porcelain )" ]; then
+            exit 0
+          else
+            echo Error: there are untracked files in the repository
+            echo The output from 'git status' is:
+            git status
+            exit 1
+          fi
+
       - name: Post-run cleanup
         if: always()
         run: find . -delete

docs/source/team.ini

@@ -32,27 +32,28 @@ Applied Physics Laboratory: https://www.apl.washington.edu/
 
 [active-team]
 # Use format
-# name : personal-webpage, image-link
+# name : personal-webpage
+# Note that if you add your name here you should also add a picture of yourself
+# in /docs/source/images.
 David A. Ham: https://www.imperial.ac.uk/people/david.ham
 Paul H. J. Kelly: https://www.imperial.ac.uk/people/p.kelly
-Lawrence Mitchell: https://www.wence.uk/
 Colin J. Cotter: https://www.imperial.ac.uk/people/colin.cotter
 Robert C. Kirby: https://www.baylor.edu/math/index.php?id=90540
 Koki Sagiyama: https://www.imperial.ac.uk/people/k.sagiyama
-Nacime Bouziani: https://www.imperial.ac.uk/people/n.bouziani18
-Thomas J. Gregory: https://www.imperial.ac.uk/people/t.gregory18
-Jack Betteridge: https://www.imperial.ac.uk/people/j.betteridge, https://avatars.githubusercontent.com/u/43041811
+Jack Betteridge: https://www.imperial.ac.uk/people/j.betteridge
 Daniel R. Shapero: https://psc.apl.uw.edu/people/investigators/daniel-shapero/
-Reuben W. Nixon-Hill: https://www.imperial.ac.uk/people/reuben.nixon-hill10
 Connor J. Ward: https://www.imperial.ac.uk/people/c.ward20
-Patrick E. Farrell: https://pefarrell.org, https://pefarrell.org/images/profile.jpg
-Pablo D. Brubeck: https://www.maths.ox.ac.uk/people/pablo.brubeckmartinez, https://avatars.githubusercontent.com/u/6486130
-India Marsden: https://www.maths.ox.ac.uk/people/india.marsden, https://pefarrell.org/images/marsden.jpg
-Daiane I. Dolci: https://www.imperial.ac.uk/people/d.dolci, https://avatars.githubusercontent.com/u/63597005?v=4
+Patrick E. Farrell: https://pefarrell.org
+Pablo D. Brubeck: https://www.maths.ox.ac.uk/people/pablo.brubeckmartinez
+India Marsden: https://www.maths.ox.ac.uk/people/india.marsden
+Daiane I. Dolci: https://www.imperial.ac.uk/people/d.dolci
 Joshua Hope-Collins: https://www.imperial.ac.uk/people/joshua.hope-collins13
-Umberto Zerbinati: https://www.uzerbinati.eu, https://www.uzerbinati.eu/assets/logo.jpeg
+Umberto Zerbinati: https://www.uzerbinati.eu
 
 [inactive-team]
+Lawrence Mitchell: https://www.wence.uk/
+Reuben W. Nixon-Hill: https://www.imperial.ac.uk/people/reuben.nixon-hill10
+Nacime Bouziani: https://www.imperial.ac.uk/people/n.bouziani18
 Sophia Vorderwuelbecke: https://www.imperial.ac.uk/people/s.vorderwuelbecke18
 Thomas H. Gibson:
 Miklós Homolya:

docs/source/team2.py

@@ -39,30 +39,11 @@ def rows(self):
         return range(self.nrows)
 
 
-def cache_web_image(name, url):
-    img_name = "".join(name.split()).lower().encode("punycode").decode()
-    img_name = img_name[:-1] if img_name[-1] == "-" else img_name
-    with urlopen(url) as response:
-        filetype = response.getheader("Content-Type")
-        ext = filetype.split("/")[1]
-        if ext == "jpeg":
-            ext = "jpg"
-        with open("images/" + img_name + "." + ext, "wb") as fh:
-            fh.write(response.read())
-
-
 # Read the current team information from configuration file
 team = ConfigParser(interpolation=ExtendedInterpolation())
 team.optionxform = lambda x: x
 team.read("team.ini")
 
-# Grab images from provided URLs and cahce them (if necessary)
-for name, links in team["active-team"].items():
-    parts = links.split(",")
-    if parts[1:]:
-        website = parts[1]
-        cache_web_image(name, website)
-
 # Environment for applying templates
 env = Environment(
     loader=FileSystemLoader("."),