DROP BEFORE MERGE

Author: ksagiyam

.github/workflows/core.yml

@@ -153,9 +153,10 @@ jobs:
               --branch $(python3 ./firedrake-repo/scripts/firedrake-configure --show-petsc-version) \
               https://gitlab.com/petsc/petsc.git
           else
-            git clone --depth 1 https://gitlab.com/petsc/petsc.git
+            git clone https://gitlab.com/petsc/petsc.git
           fi
           cd petsc
+          git checkout ksagiyam/fix_submesh_cdim
           python3 ../firedrake-repo/scripts/firedrake-configure \
             --arch ${{ matrix.arch }} --show-petsc-configure-options | \
             xargs -L1 ./configure --with-make-np=8 --download-slepc
@@ -191,7 +192,7 @@ jobs:
             : # because they rely on non-PyPI versions of petsc4py.
             pip install --no-build-isolation --no-deps \
               "$PETSC_DIR"/"$PETSC_ARCH"/externalpackages/git.slepc/src/binding/slepc4py
-            pip install --no-deps ngsPETSc netgen-mesher netgen-occt
+            pip install --no-deps git+https://github.com/ksagiyam/ngsPETSc.git@ksagiyam/remove_mesh_init netgen-mesher netgen-occt
 
             : # We have to pass '--no-build-isolation' to use a custom petsc4py
             EXTRA_BUILD_ARGS='--no-isolation'

firedrake/cython/dmcommon.pyx

@@ -1936,6 +1936,7 @@ def _set_dg_coordinates(PETSc.DM dm,
         PetscScalar *dg_coords
         const PetscScalar *firedrake_dg_coords
         PetscInt n, gdim, cStart, cEnd, c, offset, firedrake_offset, i, j, coord_size, ndof
+        PETSc.FE coord_fe
 
     gdim = firedrake_dg_coord_vec.getBlockSize()
     coord_dm = dm.getCoordinateDM()
@@ -1968,6 +1969,7 @@ def _set_dg_coordinates(PETSc.DM dm,
                                           dg_coord_vec,
                                           True)
     dm.setCellCoordinatesLocal(dg_coord_vec)
+    dm.createCoordinateSpace(1, True, False)
 
 
 @cython.boundscheck(False)

firedrake/utility_meshes.py

@@ -738,6 +738,7 @@ def TensorRectangleMesh(
     plex = mesh.plex_from_cell_list(
         2, cells, coords, comm, mesh._generate_default_mesh_topology_name(name)
     )
+    plex.createCoordinateSpace(1, False, False)
 
     # mark boundary facets
     plex.createLabel(dmcommon.FACE_SETS_LABEL)