WIP adjoint test

Author: pbrubeck

firedrake/assemble.py

@@ -832,7 +832,7 @@ def restructure_base_form(expr, visited=None):
                 replace_map = {arg: left}
                 # Decrease number for all the other arguments since the lowest numbered argument will be replaced.
                 other_args = [a for a in right.arguments() if a is not arg]
-                new_args = [firedrake.Argument(a.function_space(), number=a.number()-1, part=a.part()) for a in other_args]
+                new_args = [a.reconstruct(number=a.number()-1) for a in other_args]
                 replace_map.update(dict(zip(other_args, new_args)))
                 # Replace arguments
                 return ufl.replace(right, replace_map)
@@ -843,8 +843,8 @@ def restructure_base_form(expr, visited=None):
             u, v = B.arguments()
             # Let V1 and V2 be primal spaces, B: V1 -> V2 and B*: V2* -> V1*:
             # Adjoint(B(Argument(V1, 1), Argument(V2.dual(), 0))) = B(Argument(V1, 0), Argument(V2.dual(), 1))
-            reordered_arguments = (firedrake.Argument(u.function_space(), number=v.number(), part=v.part()),
-                                   firedrake.Argument(v.function_space(), number=u.number(), part=u.part()))
+            reordered_arguments = (u.reconstruct(number=v.number()),
+                                   v.reconstruct(number=u.number()))
             # Replace arguments in argument slots
             return ufl.replace(B, dict(zip((u, v), reordered_arguments)))
 

tests/firedrake/adjoint/test_reduced_functional.py

@@ -202,3 +202,21 @@ def test_assemble_recompute():
     h = Function(V)
     h.vector()[:] = 1
     assert taylor_test(Jhat, f, h) > 1.9
+
+
+@pytest.mark.skipcomplex
+def test_interpolate():
+    mesh = UnitSquareMesh(10, 10)
+    V = FunctionSpace(mesh, "CG", 1)
+    Q = FunctionSpace(mesh, "DG", 0)
+    c = Cofunction(Q.dual())
+    c.dat.data[:] = 1
+
+    f = Function(V)
+    f.dat.data[:] = 2
+    J = assemble(Interpolate(f, c))
+    Jhat = ReducedFunctional(J, Control(f))
+
+    h = Function(V)
+    h.dat.data[:] = 1
+    assert taylor_test(Jhat, f, h) > 1.9