Getting map_floor_div NotImplementedError for tests

[rezahousseini]

Hi

I am in the process of packaging firedrake for guix. While I made good progress, I am stuck with a repeating error message in firedrake and dependencies. I get the error message map_floor_div NotImplementedError from the package pymbolic in loopy, PyOP2 and firedrake. It is raised in the CoefficientCollector class of pymbolic.
My understanding is that the map_floor_div function needs to be implemented by the class inheriting from CoefficientCollector but I do not find any such definition. Can anybody maybe shed some light on the issue, am I completely lost?

Best, Reza

[connorjward]

It would be helpful to see install logs and a minimum failing example with a traceback. However, I would first ask, is your pymbolic up-to-date?

[connorjward]

• It looks like you are not using our fork of loopy. There may be breaking upstream changes that we haven't fixed.
• tests/unit have been moved into tests/firedrake/unit. This means you must be using an older Firedrake.
• You are using OpenMPI instead of MPICH. This is totally fine but you have to be careful in how you call pytest. Instead of pytest tests/firedrake/unit you need to run the serial and parallel tests separately:

$ pytest tests/firedrake/unit -m "not parallel"
$ mpiexec -n 3 pytest tests/firedrake/unit -m "parallel[3]"
<etc>

[rezahousseini]

Thanks, this helps a lot I am using the latets upstream version of loopy.
Regarding firedrake I use the latest version Firedrake_20241122.0 (not the master branch).
How can I distiguish between tests which need to be run in parallel and the one which not?
Has this something to do with pytest-mpi?

[connorjward]

The tests are marked. You can identify them with -m "parallel[nprocs]" (e.g. -m "parallel[3]" are all the tests run on 3 ranks).

This is from pytest-mpi but I don't think you need to look into it any deeper.

[rezahousseini]

Using the firedrake loopy I get a lot of NotImplementedError in the test (guix_loopy_build_log.txt) do you have any insights on them?

[connorjward]

I don't really understand what is going on but ultimately if you are seeing NotImplementedErrors then what must be happening is you are somehow using the wrong version of some Python library or other. My guess is probably pytools but this all seems extremely fragile.