Remove all references to Firebug theme (#5883)

juliandescottes · jasonLaster · commit 0aeeee897dbf · 2018-04-10T13:55:58.000-04:00
diff --git a/README.md b/README.md
@@ -56,7 +56,7 @@ We strive to make the Debugger as development friendly as possible. If you have
 
 | | |
 |:----:|:---:|
-|[Themes]|theming changes for light, dark, firebug|
+|[Themes]|theming changes for light, dark|
 |[Internationalization]|using or adding a localized string *(l10n)*|
 |[Prefs]|using or adding a preferences|
 |[Flow]|flow best practices and common gotchas|
diff --git a/docs/local-development.md b/docs/local-development.md
@@ -28,15 +28,15 @@
 
 ### Themes
 
-The local debugger supports three themes:
+The local debugger supports two themes:
 
-| Light                                                                                                                                                                                                                                                           | Dark                                                                                                                                                                                                                                                           | Firebug                                                                                                                                                                                                                                                           |
-| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| <a href="https://cloud.githubusercontent.com/assets/254562/20676302/4cb04a7c-b55d-11e6-855f-654395e2c26f.png"><img width="480" alt="light-theme" src="https://cloud.githubusercontent.com/assets/254562/20676302/4cb04a7c-b55d-11e6-855f-654395e2c26f.png"></a> | <a href="https://cloud.githubusercontent.com/assets/254562/20676304/4cbfbf16-b55d-11e6-9b84-3ee5595e36be.png"><img width="480" alt="dark-theme" src="https://cloud.githubusercontent.com/assets/254562/20676304/4cbfbf16-b55d-11e6-9b84-3ee5595e36be.png"></a> | <a href="https://cloud.githubusercontent.com/assets/254562/20676303/4cbb0570-b55d-11e6-98b5-d1dd124345cd.png"><img width="480" alt="firebug-theme" src="https://cloud.githubusercontent.com/assets/254562/20676303/4cbb0570-b55d-11e6-98b5-d1dd124345cd.png"></a> |
+| Light                                                                                                                                                                                                                                                           | Dark                                                                                                                                                                                                                                                           |
+| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| <a href="https://cloud.githubusercontent.com/assets/254562/20676302/4cb04a7c-b55d-11e6-855f-654395e2c26f.png"><img width="480" alt="light-theme" src="https://cloud.githubusercontent.com/assets/254562/20676302/4cb04a7c-b55d-11e6-855f-654395e2c26f.png"></a> | <a href="https://cloud.githubusercontent.com/assets/254562/20676304/4cbfbf16-b55d-11e6-9b84-3ee5595e36be.png"><img width="480" alt="dark-theme" src="https://cloud.githubusercontent.com/assets/254562/20676304/4cbfbf16-b55d-11e6-9b84-3ee5595e36be.png"></a> |
 
 #### Set a theme
 
-You can change the theme by going to the Settings panel in the launchpad and changing the theme to either `firebug` or `dark`.
+You can change the theme by going to the Settings panel in the launchpad and changing the theme to either `light` or `dark`.
 
 #### Update a theme style
 
@@ -616,7 +616,7 @@ We use [remark](https://github.com/wooorm/remark-lint) to help lint our markdown
 The Debugger has a [styleguide][mdn-colors] that we use to keep the colors consistent across tools and themes.
 
 The common colors are represented as [css variables] in a [devtools variables][devtools-css-variables] file. This lets define the colors
-for each theme: [light][light-theme], [dark][dark-theme], [firebug][firebug-theme].
+for each theme: [light][light-theme], [dark][dark-theme].
 
 ### Performance
 
@@ -843,10 +843,8 @@ your questions on [slack][slack].
 [mdn-colors]: https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors
 [light-theme]: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-launchpad/src/lib/themes/light-theme.css#L1
 [dark-theme]: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-launchpad/src/lib/themes/dark-theme.css#L1
-[firebug-theme]: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-launchpad/src/lib/themes/firebug-theme.css#L1
 [devtools-css-variables]: https://github.com/devtools-html/devtools-core/blob/master/packages/devtools-launchpad/src/lib/themes/variables.css#L1
 [css variables]: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables
-[firebug-ui-screen]: https://cloud.githubusercontent.com/assets/1755089/22209733/94970458-e1ad-11e6-83d4-8b082217b989.png
 [light-ui-screen]: https://cloud.githubusercontent.com/assets/1755089/22209736/9b194f2a-e1ad-11e6-9de0-561dd529d5f0.png
 [pr-table]: ./pull-requests.md#screenshots
 [mochitest]: ./mochitests.md
diff --git a/src/components/SecondaryPanes/Expressions.css b/src/components/SecondaryPanes/Expressions.css
@@ -79,10 +79,6 @@
   background-color: var(--theme-selection-background-hover);
 }
 
-:root.theme-firebug .expression-container:hover {
-  background-color: var(--theme-selection-background-hover);
-}
-
 .tree  .tree-node:not(.focused):hover {
   background-color: transparent;
 }
diff --git a/src/components/SecondaryPanes/Frames/Frames.css b/src/components/SecondaryPanes/Frames/Frames.css
@@ -38,8 +38,7 @@
   flex-shrink: 0;
 }
 
-.theme-light .frames .location,
-.theme-firebug .frames .location {
+.theme-light .frames .location {
   color: var(--theme-comment);
 }
 
@@ -74,7 +73,6 @@
 }
 
 :root.theme-light .frames ul li.selected .location,
-:root.theme-firebug .frames ul li.selected .location,
 :root.theme-dark .frames ul li.selected .location {
   color: white;
 }
diff --git a/src/components/shared/reps.css b/src/components/shared/reps.css
@@ -16,18 +16,6 @@
   --reference-color: var(--theme-highlight-purple);
 }
 
-.theme-firebug {
-  --number-color: #000088;
-  --string-color: #ff0000;
-  --null-color: #787878;
-  --object-color: DarkGreen;
-  --caption-color: #444444;
-  --location-color: #555555;
-  --source-link-color: blue;
-  --node-color: rgb(0, 0, 136);
-  --reference-color: rgb(102, 102, 255);
-}
-
 /******************************************************************************/
 
 .objectLink:hover {

Original file line number	Diff line number	Diff line change
`@@ -79,10 +79,6 @@`
`79`	`79`	`background-color: var(--theme-selection-background-hover);`
`80`	`80`	`}`
`81`	`81`
`82`		`-:root.theme-firebug .expression-container:hover {`
`83`		`- background-color: var(--theme-selection-background-hover);`
`84`		`-}`
`85`		`-`
`86`	`82`	`.tree .tree-node:not(.focused):hover {`
`87`	`83`	`background-color: transparent;`
`88`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,7 @@`
`38`	`38`	`flex-shrink: 0;`
`39`	`39`	`}`
`40`	`40`
`41`		`-.theme-light .frames .location,`
`42`		`-.theme-firebug .frames .location {`
	`41`	`+.theme-light .frames .location {`
`43`	`42`	`color: var(--theme-comment);`
`44`	`43`	`}`
`45`	`44`
`@@ -74,7 +73,6 @@`
`74`	`73`	`}`
`75`	`74`
`76`	`75`	`:root.theme-light .frames ul li.selected .location,`
`77`		`-:root.theme-firebug .frames ul li.selected .location,`
`78`	`76`	`:root.theme-dark .frames ul li.selected .location {`
`79`	`77`	`color: white;`
`80`	`78`	`}`