Remove re-used accesskeys (#3009)

Author: jasonLaster

assets/panel/debugger.properties

@@ -316,13 +316,17 @@ editor.jumpToMappedLocation1=Jump to %S location
 # context menu to disable framework grouping.
 framework.disableGrouping=Disable Framework Grouping
 
+# LOCALIZATION NOTE (framework.disableGrouping.accesskey): Access key to toggle
+# framework grouping from the context menu.
+framework.disableGrouping.accesskey=u
+
 # LOCALIZATION NOTE (framework.enableGrouping): This is the text that appears in the
 # context menu to enable framework grouping.
 framework.enableGrouping=Enable Framework Grouping
 
-# LOCALIZATION NOTE (framework.accesskey): Access key to toggle framework grouping from
-# the context menu.
-framework.accesskey=u
+# LOCALIZATION NOTE (framework.enableGrouping.accesskey): Access key to toggle
+# framework grouping from the context menu.
+framework.enableGrouping.accesskey=u
 
 # LOCALIZATION NOTE (generated): Source Map term for a server source location
 generated=generated
@@ -398,6 +402,10 @@ sourceFooter.blackbox=Blackbox Source
 # with the blackbox button
 sourceFooter.unblackbox=Unblackbox Source
 
+# LOCALIZATION NOTE (sourceFooter.unblackbox.accesskey): Access key to blackbox
+# an associated source
+sourceFooter.unblackbox.accesskey=b
+
 # LOCALIZATION NOTE (sourceFooter.blackbox.accesskey): Access key to blackbox
 # an associated source
 sourceFooter.blackbox.accesskey=b

src/components/SecondaryPanes/Frames/FrameMenu.js

@@ -7,16 +7,14 @@ import kebabCase from "lodash.kebabcase";
 
 const blackboxString = "sourceFooter.blackbox";
 const unblackboxString = "sourceFooter.unblackbox";
-const blackboxKeyString = "sourceFooter.blackbox.accesskey";
 
 function formatMenuElement(
   labelString: string,
-  accesskeyString: string,
   click: Function,
   disabled: boolean = false
 ): ContextMenuItem {
   const label = L10N.getStr(labelString);
-  const accesskey = L10N.getStr(accesskeyString);
+  const accesskey = L10N.getStr(`${labelString}.accesskey`);
   const id = `node-menu-${kebabCase(label)}`;
   return {
     id,
@@ -28,15 +26,11 @@ function formatMenuElement(
 }
 
 function copySourceElement(url) {
-  return formatMenuElement("copySourceUrl", "copySourceUrl.accesskey", () =>
-    copyToTheClipboard(url)
-  );
+  return formatMenuElement("copySourceUrl", () => copyToTheClipboard(url));
 }
 
 function copyStackTraceElement(copyStackTrace) {
-  return formatMenuElement("copyStackTrace", "copyStackTrace.accesskey", () =>
-    copyStackTrace()
-  );
+  return formatMenuElement("copyStackTrace", () => copyStackTrace());
 }
 
 function toggleFrameworkGroupingElement(
@@ -47,19 +41,15 @@ function toggleFrameworkGroupingElement(
     ? "framework.disableGrouping"
     : "framework.enableGrouping";
 
-  return formatMenuElement(actionType, "framework.accesskey", () =>
-    toggleFrameworkGrouping()
-  );
+  return formatMenuElement(actionType, () => toggleFrameworkGrouping());
 }
 
 function blackBoxSource(source, toggleBlackBox) {
   const toggleBlackBoxString = source.isBlackBoxed
     ? unblackboxString
     : blackboxString;
 
-  return formatMenuElement(toggleBlackBoxString, blackboxKeyString, () =>
-    toggleBlackBox(source)
-  );
+  return formatMenuElement(toggleBlackBoxString, () => toggleBlackBox(source));
 }
 
 export default function FrameMenu(