Expression syntax errors are cleared on save (#5678)

* [Expression] syntax errors are cleared on save

Modified 1 file:
src/components/SecondaryPanes/Expression.js

* [Expression] syntax errors are cleared on save

Modified 1 file:
src/actions/expressions.js

* [Expression] syntax errors are cleared on save

Modified 1 file:
src/components/SecondaryPanes/Expression.js

* [Expression] syntax errors are cleared on save

Modified 1 file:
src/components/SecondaryPanes/Expression.js

* Lint cleanup

Author: marcogallo566

src/actions/expressions.js

@@ -34,12 +34,13 @@ export function addExpression(input: string) {
       return;
     }
 
+    const expressionError = await parser.hasSyntaxError(input);
+
     const expression = getExpression(getState(), input);
     if (expression) {
       return dispatch(evaluateExpression(expression));
     }
 
-    const expressionError = await parser.hasSyntaxError(input);
     dispatch({ type: "ADD_EXPRESSION", input, expressionError });
 
     const newExpression = getExpression(getState(), input);

src/components/SecondaryPanes/Expressions.js

@@ -121,14 +121,22 @@ class Expressions extends Component<Props, State> {
   ) => {
     e.preventDefault();
     e.stopPropagation();
+
     this.props.updateExpression(this.state.inputValue, expression);
   };
 
   handleNewSubmit = async (e: SyntheticEvent<HTMLFormElement>) => {
+    const { inputValue } = this.state;
     e.preventDefault();
     e.stopPropagation();
-    this.props.addExpression(this.state.inputValue);
-    this.setState({ editing: false, editIndex: -1, inputValue: "" });
+
+    this.props.clearExpressionError();
+    await this.props.addExpression(this.state.inputValue);
+    this.setState({
+      editing: false,
+      editIndex: -1,
+      inputValue: this.props.expressionError ? inputValue : ""
+    });
   };
 
   renderExpression = (expression: Expression, index: number) => {