|
| 1 | +### February 28th |
| 2 | + |
| 3 | +#### Overview |
| 4 | + |
| 5 | +Last week was nothing short or epic. |
| 6 | + |
| 7 | +1. We made tons of progress on function search, text search, and editor preview |
| 8 | +2. We squashed mountains of UI and perf bugs |
| 9 | +3. We added great features to the scopes pane |
| 10 | +4. We focused on integration testing and general QA. |
| 11 | + |
| 12 | +There's no way we could have gotten this done without the help of many people: [@rrandom], [@arthur801031], [@bomsy], [@wldcordeiro], [@jryans], [@irfanhudda], [@soapdog], [@amitzur], [@juliandescottes], [@Garbee], [@zystvan], [@najamkhn], [@jcreighton], [@jbhoosreddy], [@tromey], [@ryanjduffy], [@sole], [@lasfin]! |
| 13 | + |
| 14 | +#### UI |
| 15 | + |
| 16 | +We fixed UI bugs ranging from themes, to accessibility, to RTL. It was an unbelievable team effort. |
| 17 | + |
| 18 | +* [Fix tab close button positioning][pr-12] - [@wldcordeiro] |
| 19 | +* [Issue 1946: adding Conditional Breakpoint guillemet][pr-19] - [@soapdog] |
| 20 | +* [Restore tooltips for debug buttons][pr-20] - [@irfanhudda] |
| 21 | +* [Expand source directories on click][pr-23] - [@wldcordeiro] |
| 22 | +* [Make the command bar sticky.][pr-35] - [@Garbee] |
| 23 | +* [Align Text Vertically in Watch Expressions Panel Section][pr-36] - [@zystvan] |
| 24 | +* [fix frame location color change on hover][pr-43] - [@jcreighton] |
| 25 | +* [use scrollIntoView to improve result scrolling (#2106)][pr-44] - [@jbhoosreddy] |
| 26 | +* [Refactor Searching UI into smaller components and clean up function search UI][pr-45] - [@wldcordeiro] |
| 27 | +* [Add close button to conditional breakpoint panel][pr-49] - [@ryanjduffy] |
| 28 | +* [Style the searchbar height so the result list doesn't go on forever][pr-52] - [@wldcordeiro] |
| 29 | +* [Fix icons dark theme][pr-54] - [@jcreighton] |
| 30 | +* [add chrome scrolling polyfill][pr-59] - [@jasonLaster] |
| 31 | +* [(Accessibility) select frame on enter][pr-66] - [@lasfin] |
| 32 | +* [Polish ui catchall][pr-67] - [@jasonLaster] |
| 33 | +* [refactor why-paused component to use a react class and props][pr-9] - [@jasonLaster] |
| 34 | + |
| 35 | + |
| 36 | +#### Bug Fixes |
| 37 | + |
| 38 | +Thanks [@juliandescottes], [@bomsy], [@irfanhudda] for coming in and fixing some pretty embarressing bugs! |
| 39 | + |
| 40 | +* [Fix source navigation, when switching from vertical to horizontal layouunlink][pr-32] - [@juliandescottes] |
| 41 | +* [Fix watch expression editing][pr-28] - [@bomsy] |
| 42 | +* [Address perf issues with source maps][pr-42] - [@jasonLaster] |
| 43 | +* [Fix sources highlight][pr-53] - [@irfanhudda] |
| 44 | +* [Speed up opening the editor][pr-68] - [@jasonLaster] |
| 45 | + |
| 46 | +#### Text Search |
| 47 | + |
| 48 | +Text search `cmd+f` is a surprisingly challenging feature that we've been working on since September. |
| 49 | +This week, we nailed down some of the most complicated behavior around iterating through results, especially when cursor state changes. |
| 50 | + |
| 51 | +* [Improve text search result count][pr-0] - [@rrandom] |
| 52 | +* [EditorSearch index fix][pr-11] - [@jasonLaster] |
| 53 | +* [Fix search selection][pr-13] - [@jasonLaster] |
| 54 | +* [Add a search bottom bar and move the search modifiers to the bottom bar.][pr-21] - [@wldcordeiro] |
| 55 | +* [Fix whole word search modifier clearing search and count showing as NaN][pr-63] - [@wldcordeiro] |
| 56 | +* [Fix modifier buttons in chrome][pr-64] - [@wldcordeiro] |
| 57 | +* [Don't run text search when function search is enabled.][pr-69] - [@wldcordeiro] |
| 58 | + |
| 59 | +#### Function Search |
| 60 | + |
| 61 | +Function Search was a stretch goal for our release going into the week. |
| 62 | +Thanks to [babel.js](https://babeljs.io/) having a fantastic API and the heroic effort of [@clarkbw] and [@wldcordeiro] |
| 63 | +on the UI we'll be able to launch a really beautiful feature. |
| 64 | + |
| 65 | +* [use a unique id to show multiple matches in function search][pr-2] - [@clarkbw] |
| 66 | +* [implement the function search compact design][pr-5] - [@clarkbw] |
| 67 | +* [Update parser][pr-24] - [@jasonLaster] |
| 68 | +* [Move the function search into the editor search bar][pr-27] [2][pr-30] - [@wldcordeiro] |
| 69 | +* [Disable the search modifiers when function search is enabled.][pr-60] - [@wldcordeiro] |
| 70 | +* [Fix search results height in chrome.][pr-65] - [@wldcordeiro] |
| 71 | +* [Polish search toggle UX][pr-70] - [@wldcordeiro] |
| 72 | +* [Add summary messages for the function searching][pr-71] - [@wldcordeiro] |
| 73 | + |
| 74 | +#### Scopes |
| 75 | + |
| 76 | +The scopes component is one of the most used features of a Debugger and also introduces some of the most complexity. |
| 77 | +This week we looked at showing promises, large arrrays, sparse arrays. |
| 78 | +[@Bomsy] also tackled keeping variables expanded as the debugger steps through the code. This was a difficulty `hard` bug! |
| 79 | + |
| 80 | +* [Persist scopes as you step][pr-6] - [@bomsy] |
| 81 | +* [Add buckets for objects and keys][pr-22] - [@jasonLaster] |
| 82 | +* [Show promises special properties (status, reason)][pr-51] - [@arthur801031] |
| 83 | +* [Show falsey return values][pr-58] - [@tromey] |
| 84 | + |
| 85 | +#### Editor Preview |
| 86 | + |
| 87 | +Editor Preview is the one new **must** have feature of the release. |
| 88 | +We were blocked on adding the feature, while we waited for parser support. This week we built a fantastic V1, which supports hovering on local variables and a really nice custom preview for functions and objects. In the case of functions, we also provide a link to the function definition. |
| 89 | + |
| 90 | +* [Editor popover][pr-29] - [@amitzur] |
| 91 | +* [Add Popup Preview (V1)][pr-40] - [@jasonLaster] |
| 92 | +* [Preview objects, functions, and reps][pr-57] - [@jasonLaster] |
| 93 | +* [Show editor preview on hover][pr-61] - [@bomsy] |
| 94 | + |
| 95 | + |
| 96 | +#### Infrastructure |
| 97 | + |
| 98 | +* [Add flow to Scopes.js, WhyPaused.js, SourcesTree.js,...][pr-1] - [@arthur801031] |
| 99 | +* [fix the invalid source texts in the failing tests][pr-4] - [@bomsy] |
| 100 | +* [add yarn run links script][pr-8] - [@clarkbw] |
| 101 | +* [Add flow to Autocomplete.js, Close.js, PaneToggle.js,...][pr-10] - [@arthur801031] |
| 102 | +* [update lint script to better capture directory layout][pr-14] - [@clarkbw] |
| 103 | +* [Document Firefox WebSocket workflow][pr-15] - [@jryans] |
| 104 | +* [Replace custom utilities with lodash utils where possible][pr-25] - [@clarkbw] |
| 105 | +* [Fix the nom command to remove yarn.lock file][pr-41] - [@najamkhn] |
| 106 | + |
| 107 | +#### Miscellaneous |
| 108 | + |
| 109 | +* [cleanup l10n accesskey properties][pr-55] - [@jasonLaster] |
| 110 | +* [Remove required status from prop in searchbar and fix flow issues.][pr-48] - [@wldcordeiro] |
| 111 | + |
| 112 | +#### Testing |
| 113 | + |
| 114 | +* [add Tests for Return values][pr-33] - [@jasonLaster] |
| 115 | +* [Additional integration tests][pr-18] - [@jasonLaster] |
| 116 | +* [fix failing tests][pr-3] - [@jasonLaster] |
| 117 | +* [Add Expressions test][pr-37] - [@bomsy] |
| 118 | +* [fix console link test][pr-38] - [@jasonLaster] |
| 119 | + |
| 120 | +#### Docs |
| 121 | + |
| 122 | +* [(WIP) integration test docs][pr-16] - [@jasonLaster] |
| 123 | +* [clean up testing docs][pr-34] - [@jasonLaster] |
| 124 | +* [Add some maintainer docs][pr-47] - [@jasonLaster] |
| 125 | + |
| 126 | +#### Screenshots |
| 127 | + |
| 128 | +| Persist Scopes | |
| 129 | +|----------------| |
| 130 | +|![gif-1]| |
| 131 | + |
| 132 | +| Editor Preview | |
| 133 | +|----------------| |
| 134 | +|![gif-2]| |
| 135 | + |
| 136 | +| Text Search | |
| 137 | +|-------------| |
| 138 | +|![gif-3]! |
| 139 | + |
| 140 | + |
| 141 | +[gif-1]:https://cloud.githubusercontent.com/assets/792924/23188424/948ff100-f886-11e6-9420-bab20d56d289.gif |
| 142 | +[gif-2]:https://cloud.githubusercontent.com/assets/792924/23385436/b5e22ae2-fd47-11e6-9a55-e26365b3849e.gif |
| 143 | +[gif-3]:https://camo.githubusercontent.com/c528900a4ca7a817e34cd43bd0d8a9f44c4c3a6e/687474703a2f2f672e7265636f726469742e636f2f494d385370645a784d722e676966 |
| 144 | + |
| 145 | +[pr-0]:https://github.com/devtools-html/debugger.html/pull/2005 |
| 146 | +[pr-1]:https://github.com/devtools-html/debugger.html/pull/2048 |
| 147 | +[pr-2]:https://github.com/devtools-html/debugger.html/pull/2058 |
| 148 | +[pr-3]:https://github.com/devtools-html/debugger.html/pull/2061 |
| 149 | +[pr-4]:https://github.com/devtools-html/debugger.html/pull/2062 |
| 150 | +[pr-5]:https://github.com/devtools-html/debugger.html/pull/2047 |
| 151 | +[pr-6]:https://github.com/devtools-html/debugger.html/pull/2064 |
| 152 | +[pr-7]:https://github.com/devtools-html/debugger.html/pull/2074 |
| 153 | +[pr-8]:https://github.com/devtools-html/debugger.html/pull/2073 |
| 154 | +[pr-9]:https://github.com/devtools-html/debugger.html/pull/2071 |
| 155 | +[pr-10]:https://github.com/devtools-html/debugger.html/pull/2069 |
| 156 | +[pr-11]:https://github.com/devtools-html/debugger.html/pull/2067 |
| 157 | +[pr-12]:https://github.com/devtools-html/debugger.html/pull/2043 |
| 158 | +[pr-13]:https://github.com/devtools-html/debugger.html/pull/2068 |
| 159 | +[pr-14]:https://github.com/devtools-html/debugger.html/pull/2086 |
| 160 | +[pr-15]:https://github.com/devtools-html/debugger.html/pull/2111 |
| 161 | +[pr-16]:https://github.com/devtools-html/debugger.html/pull/2095 |
| 162 | +[pr-17]:https://github.com/devtools-html/debugger.html/pull/2110 |
| 163 | +[pr-18]:https://github.com/devtools-html/debugger.html/pull/2089 |
| 164 | +[pr-19]:https://github.com/devtools-html/debugger.html/pull/2088 |
| 165 | +[pr-20]:https://github.com/devtools-html/debugger.html/pull/2099 |
| 166 | +[pr-21]:https://github.com/devtools-html/debugger.html/pull/2119 |
| 167 | +[pr-22]:https://github.com/devtools-html/debugger.html/pull/2026 |
| 168 | +[pr-23]:https://github.com/devtools-html/debugger.html/pull/2087 |
| 169 | +[pr-24]:https://github.com/devtools-html/debugger.html/pull/2092 |
| 170 | +[pr-25]:https://github.com/devtools-html/debugger.html/pull/2114 |
| 171 | +[pr-26]:https://github.com/devtools-html/debugger.html/pull/2063 |
| 172 | +[pr-27]:https://github.com/devtools-html/debugger.html/pull/2121 |
| 173 | +[pr-28]:https://github.com/devtools-html/debugger.html/pull/2118 |
| 174 | +[pr-29]:https://github.com/devtools-html/debugger.html/pull/2090 |
| 175 | +[pr-30]:https://github.com/devtools-html/debugger.html/pull/2139 |
| 176 | +[pr-31]:https://github.com/devtools-html/debugger.html/pull/2138 |
| 177 | +[pr-32]:https://github.com/devtools-html/debugger.html/pull/2129 |
| 178 | +[pr-33]:https://github.com/devtools-html/debugger.html/pull/2133 |
| 179 | +[pr-34]:https://github.com/devtools-html/debugger.html/pull/2136 |
| 180 | +[pr-35]:https://github.com/devtools-html/debugger.html/pull/2128 |
| 181 | +[pr-36]:https://github.com/devtools-html/debugger.html/pull/2142 |
| 182 | +[pr-37]:https://github.com/devtools-html/debugger.html/pull/2145 |
| 183 | +[pr-38]:https://github.com/devtools-html/debugger.html/pull/2147 |
| 184 | +[pr-39]:https://github.com/devtools-html/debugger.html/pull/2168 |
| 185 | +[pr-40]:https://github.com/devtools-html/debugger.html/pull/2153 |
| 186 | +[pr-41]:https://github.com/devtools-html/debugger.html/pull/2152 |
| 187 | +[pr-42]:https://github.com/devtools-html/debugger.html/pull/2140 |
| 188 | +[pr-43]:https://github.com/devtools-html/debugger.html/pull/2155 |
| 189 | +[pr-44]:https://github.com/devtools-html/debugger.html/pull/2166 |
| 190 | +[pr-45]:https://github.com/devtools-html/debugger.html/pull/2150 |
| 191 | +[pr-46]:https://github.com/devtools-html/debugger.html/pull/2183 |
| 192 | +[pr-47]:https://github.com/devtools-html/debugger.html/pull/2181 |
| 193 | +[pr-48]:https://github.com/devtools-html/debugger.html/pull/2188 |
| 194 | +[pr-49]:https://github.com/devtools-html/debugger.html/pull/2179 |
| 195 | +[pr-50]:https://github.com/devtools-html/debugger.html/pull/2189 |
| 196 | +[pr-51]:https://github.com/devtools-html/debugger.html/pull/2146 |
| 197 | +[pr-52]:https://github.com/devtools-html/debugger.html/pull/2170 |
| 198 | +[pr-53]:https://github.com/devtools-html/debugger.html/pull/2176 |
| 199 | +[pr-54]:https://github.com/devtools-html/debugger.html/pull/2174 |
| 200 | +[pr-55]:https://github.com/devtools-html/debugger.html/pull/2162 |
| 201 | +[pr-56]:https://github.com/devtools-html/debugger.html/pull/2212 |
| 202 | +[pr-57]:https://github.com/devtools-html/debugger.html/pull/2187 |
| 203 | +[pr-58]:https://github.com/devtools-html/debugger.html/pull/2216 |
| 204 | +[pr-59]:https://github.com/devtools-html/debugger.html/pull/2202 |
| 205 | +[pr-60]:https://github.com/devtools-html/debugger.html/pull/2198 |
| 206 | +[pr-61]:https://github.com/devtools-html/debugger.html/pull/2191 |
| 207 | +[pr-62]:https://github.com/devtools-html/debugger.html/pull/2201 |
| 208 | +[pr-63]:https://github.com/devtools-html/debugger.html/pull/2200 |
| 209 | +[pr-64]:https://github.com/devtools-html/debugger.html/pull/2197 |
| 210 | +[pr-65]:https://github.com/devtools-html/debugger.html/pull/2210 |
| 211 | +[pr-66]:https://github.com/devtools-html/debugger.html/pull/2182 |
| 212 | +[pr-67]:https://github.com/devtools-html/debugger.html/pull/2209 |
| 213 | +[pr-68]:https://github.com/devtools-html/debugger.html/pull/2190 |
| 214 | +[pr-69]:https://github.com/devtools-html/debugger.html/pull/2192 |
| 215 | +[pr-70]:https://github.com/devtools-html/debugger.html/pull/2211 |
| 216 | +[pr-71]:https://github.com/devtools-html/debugger.html/pull/2194 |
| 217 | +[@rrandom]:http://github.com/rrandom |
| 218 | +[@arthur801031]:http://github.com/arthur801031 |
| 219 | +[@clarkbw]:http://github.com/clarkbw |
| 220 | +[@jasonLaster]:http://github.com/jasonLaster |
| 221 | +[@bomsy]:http://github.com/bomsy |
| 222 | +[@wldcordeiro]:http://github.com/wldcordeiro |
| 223 | +[@jryans]:http://github.com/jryans |
| 224 | +[@irfanhudda]:http://github.com/irfanhudda |
| 225 | +[@soapdog]:http://github.com/soapdog |
| 226 | +[@amitzur]:http://github.com/amitzur |
| 227 | +[@juliandescottes]:http://github.com/juliandescottes |
| 228 | +[@Garbee]:http://github.com/Garbee |
| 229 | +[@zystvan]:http://github.com/zystvan |
| 230 | +[@najamkhn]:http://github.com/najamkhn |
| 231 | +[@jcreighton]:http://github.com/jcreighton |
| 232 | +[@jbhoosreddy]:http://github.com/jbhoosreddy |
| 233 | +[@tromey]:http://github.com/tromey |
| 234 | +[@ryanjduffy]:http://github.com/ryanjduffy |
| 235 | +[@sole]:http://github.com/sole |
| 236 | +[@lasfin]:http://github.com/lasfin |
0 commit comments