Support pausing immediately (#5076)

Author: jasonLaster

src/actions/navigation.js

@@ -41,13 +41,13 @@ export function willNavigate(_: any, event: Object) {
     clearASTs();
     clearScopes();
     clearSources();
-    sourceQueue.clear();
-
     dispatch(navigate(event.url));
   };
 }
 
 export function navigate(url: string) {
+  sourceQueue.clear();
+
   return {
     type: "NAVIGATE",
     url

src/client/firefox/events.js

@@ -61,7 +61,7 @@ async function paused(_: "paused", packet: PausedPacket) {
 
   if (why.type != "alreadyPaused") {
     const pause = createPause(packet, response);
-    sourceQueue.flush();
+    await sourceQueue.flush();
     actions.paused(pause);
   }
 }

src/test/mochitest/browser_dbg-sourcemaps-reloading.js

@@ -27,14 +27,18 @@ add_task(async function() {
     "Breakpoint has correct line"
   );
 
+  await addBreakpoint(dbg, entrySrc, 5);
   await addBreakpoint(dbg, entrySrc, 15);
   await disableBreakpoint(dbg, entrySrc, 15);
 
   // Test reloading the debugger
   await reload(dbg, "opts.js");
   await waitForDispatch(dbg, "LOAD_SOURCE_TEXT");
 
-  is(getBreakpoints(getState()).size, 2, "One breakpoint exists");
+  await waitForPaused(dbg);
+  assertPausedLocation(dbg);
+
+  is(getBreakpoints(getState()).size, 3, "Three breakpoints exist");
 
   ok(
     getBreakpoint(getState(), { sourceId: entrySrc.id, line: 13 }),

src/utils/source-queue.js

@@ -2,20 +2,19 @@ import { throttle } from "lodash";
 
 let newSources;
 let createSource;
-let queuedSources;
 let supportsWasm = false;
+let queuedSources;
 
-const queue = throttle(() => {
-  if (!newSources || !createSource) {
-    return;
-  }
-  newSources(
-    queuedSources.map(source => {
-      return createSource(source, { supportsWasm });
-    })
-  );
+async function dispatchNewSources() {
+  const sources = queuedSources;
   queuedSources = [];
-}, 100);
+
+  await newSources(
+    sources.map(source => createSource(source, { supportsWasm }))
+  );
+}
+
+const queue = throttle(dispatchNewSources, 100);
 
 export default {
   initialize: options => {