[Scopes] Avoid exceptions when import bindings are optimized away. (#5722)

Author: loganfsmyth

src/test/mochitest/browser_dbg-babel-preview.js

@@ -165,33 +165,33 @@ add_task(async function() {
     },
   ]);
 
-  await breakpointPreviews(dbg, "imported-bindings", { line: 17, column: 2 }, [
+  await breakpointPreviews(dbg, "imported-bindings", { line: 20, column: 2 }, [
     {
-      line: 19,
+      line: 22,
       column: 16,
       expression: "_mod2.default;",
       result: '"a-default"',
     },
     {
-      line: 20,
+      line: 23,
       column: 16,
       expression: "_mod4.original;",
       result: '"an-original"',
     },
     {
-      line: 21,
+      line: 24,
       column: 16,
       expression: "_mod3.aNamed;",
       result: '"a-named"',
     },
     {
-      line: 22,
+      line: 25,
       column: 16,
       expression: "_mod4.original;",
       result: '"an-original"',
     },
     {
-      line: 23,
+      line: 26,
       column: 16,
       expression: "aNamespace;",
       fields: [
@@ -200,31 +200,31 @@ add_task(async function() {
       ],
     },
     {
-      line: 28,
+      line: 31,
       column: 20,
       expression: "_mod7.default;",
       result: '"a-default2"',
     },
     {
-      line: 29,
+      line: 32,
       column: 20,
       expression: "_mod9.original;",
       result: '"an-original2"',
     },
     {
-      line: 30,
+      line: 33,
       column: 20,
       expression: "_mod8.aNamed2;",
       result: '"a-named2"',
     },
     {
-      line: 31,
+      line: 34,
       column: 20,
       expression: "_mod9.original;",
       result: '"an-original2"',
     },
     {
-      line: 32,
+      line: 35,
       column: 20,
       expression: "aNamespace2;",
       fields: [

src/test/mochitest/browser_dbg-babel-scopes.js

@@ -160,7 +160,7 @@ add_task(async function() {
 
   // Babel 6's imports aren't fully mapped, so they show as unavailable.
   // The call-based ones work, but the single-identifier ones do not.
-  await breakpointScopes(dbg, "imported-bindings", { line: 17, column: 2 }, [
+  await breakpointScopes(dbg, "imported-bindings", { line: 20, column: 2 }, [
     "Module",
     ["aDefault", '"a-default"'],
     ["aDefault2", '"a-default2"'],
@@ -174,6 +174,7 @@ add_task(async function() {
     ["aNamespace", "{\u2026}"],
     ["aNamespace2", "{\u2026}"],
     ["aNamespace3", "{\u2026}"],
+    ["optimizedOut", "(optimized away)"],
     "root()"
   ]);
 
@@ -307,7 +308,7 @@ add_task(async function() {
     "root()"
   ]);
 
-  await breakpointScopes(dbg, "webpack-modules", { line: 17, column: 2 }, [
+  await breakpointScopes(dbg, "webpack-modules", { line: 20, column: 2 }, [
     "Module",
     ["aDefault", '"a-default"'],
     ["aDefault2", '"a-default2"'],
@@ -321,10 +322,11 @@ add_task(async function() {
     ["aNamespace", "{\u2026}"],
     ["aNamespace2", "{\u2026}"],
     ["aNamespace3", "{\u2026}"],
+    ["optimizedOut", "(optimized away)"],
     "root()"
   ]);
 
-  await breakpointScopes(dbg, "webpack-modules-es6", { line: 17, column: 2 }, [
+  await breakpointScopes(dbg, "webpack-modules-es6", { line: 20, column: 2 }, [
     "Module",
     ["aDefault", '"a-default"'],
     ["aDefault2", '"a-default2"'],
@@ -338,6 +340,7 @@ add_task(async function() {
     ["aNamespace", "{\u2026}"],
     ["aNamespace2", "{\u2026}"],
     ["aNamespace3", "{\u2026}"],
+    ["optimizedOut", "(optimized away)"],
     "root()"
   ]);
 

src/test/mochitest/examples/babel/fixtures/imported-bindings/input.js

@@ -13,6 +13,9 @@ import { aNamed3 } from "./src/mod10";
 import { original as anAliased3 } from "./src/mod11";
 import * as aNamespace3 from "./src/mod12";
 
+import optimizedOut from "./src/optimized-out";
+optimizedOut();
+
 export default function root() {
   console.log("pause here", root);
 

src/test/mochitest/examples/babel/fixtures/imported-bindings/output.js

@@ -0,0 +1 @@
+export default function optimizedOut() {}

src/test/mochitest/examples/babel/fixtures/imported-bindings/output.js.map

@@ -13,6 +13,9 @@ import { aNamed3 } from "./src/mod10";
 import { original as anAliased3 } from "./src/mod11";
 import * as aNamespace3 from "./src/mod12";
 
+import optimizedOut from "./src/optimized-out";
+optimizedOut();
+
 export default function root() {
   console.log("pause here", root);