Do not add jump to definition icon for evaled in debugger functions.

Fixes #862.

Author: nchevobbe

packages/devtools-reps/src/reps/function.js

@@ -18,6 +18,8 @@ const Svg = require("../shared/images/Svg");
 const dom = require("react-dom-factories");
 const { span } = dom;
 
+const IGNORED_SOURCE_URLS = ["debugger eval code"];
+
 /**
  * This component represents a template for Function objects.
  */
@@ -34,7 +36,11 @@ function FunctionRep(props) {
   } = props;
 
   let jumpToDefinitionButton;
-  if (onViewSourceInDebugger && grip.location && grip.location.url) {
+  if (onViewSourceInDebugger &&
+    grip.location &&
+    grip.location.url &&
+    !IGNORED_SOURCE_URLS.includes(grip.location.url)
+  ) {
     jumpToDefinitionButton = Svg("jump-definition", {
       element: "a",
       draggable: false,

packages/devtools-reps/src/reps/stubs/function.js

@@ -152,4 +152,36 @@ stubs.set("AnonGeneratorFunction", {
   }
 });
 
+stubs.set("getRandom", {
+  "type": "object",
+  "actor": "server1.conn7.child1/obj984",
+  "class": "Function",
+  "extensible": true,
+  "frozen": false,
+  "sealed": false,
+  "ownPropertyLength": 3,
+  "name": "getRandom",
+  "displayName": "getRandom",
+  "location": {
+    "url": "https://nchevobbe.github.io/demo/console-test-app.html",
+    "line": 314
+  }
+});
+
+stubs.set("EvaledInDebuggerFunction", {
+  "type": "object",
+  "actor": "server1.conn2.child1/obj29",
+  "class": "Function",
+  "extensible": true,
+  "frozen": false,
+  "sealed": false,
+  "ownPropertyLength": 3,
+  "name": "evaledInDebugger",
+  "displayName": "evaledInDebugger",
+  "location": {
+    "url": "debugger eval code",
+    "line": 1
+  }
+});
+
 module.exports = stubs;

packages/devtools-reps/src/reps/tests/function.js

@@ -239,7 +239,7 @@ describe("Function - Anonymous generator function", () => {
 describe("Function - Jump to definition", () => {
   it("renders an icon when onViewSourceInDebugger props is provided", () => {
     const onViewSourceInDebugger = jest.fn();
-    const object = stubs.get("Named");
+    const object = stubs.get("getRandom");
     const renderedComponent = renderRep(object, {
       onViewSourceInDebugger
     });
@@ -256,15 +256,15 @@ describe("Function - Jump to definition", () => {
   });
 
   it("does not render an icon when onViewSourceInDebugger props is not provided", () => {
-    const object = stubs.get("Named");
+    const object = stubs.get("getRandom");
     const renderedComponent = renderRep(object);
 
     const node = renderedComponent.find(".jump-definition");
     expect(node.exists()).toBeFalsy();
   });
 
   it("does not render an icon when the object has no location", () => {
-    const object = Object.assign({}, stubs.get("Named"));
+    const object = Object.assign({}, stubs.get("getRandom"));
     delete object.location;
     const renderedComponent = renderRep(object, {
       onViewSourceInDebugger: () => {}
@@ -275,7 +275,7 @@ describe("Function - Jump to definition", () => {
   });
 
   it("does not render an icon when the object has no url location", () => {
-    const object = Object.assign({}, stubs.get("Named"));
+    const object = Object.assign({}, stubs.get("getRandom"));
     object.location.url = null;
     const renderedComponent = renderRep(object, {
       onViewSourceInDebugger: () => {}
@@ -284,6 +284,16 @@ describe("Function - Jump to definition", () => {
     const node = renderedComponent.find(".jump-definition");
     expect(node.exists()).toBeFalsy();
   });
+
+  it("does not render an icon when function was declared in console input", () => {
+    const object = Object.assign({}, stubs.get("EvaledInDebuggerFunction"));
+    const renderedComponent = renderRep(object, {
+      onViewSourceInDebugger: () => {}
+    });
+
+    const node = renderedComponent.find(".jump-definition");
+    expect(node.exists()).toBeFalsy();
+  });
 });
 
 describe("Function - Simplify name", () => {