Early return & strip fixtures from unnecessary properties.

Author: nchevobbe

packages/devtools-reps/src/object-inspector/tests/utils/make-node-for-properties.js

@@ -46,45 +46,19 @@ describe("makeNodesForProperties", () => {
         ownProperties: {
           foo: { value: "foo" },
           bar: {
-            "configurable": true,
-            "enumerable": true,
             "get": {
               "type": "object",
-              "actor": "server2.conn1.child1/obj106",
-              "class": "Function",
-              "extensible": true,
-              "frozen": false,
-              "sealed": false,
-              "name": "get x",
-              "displayName": "get x",
-              "location": {
-                "url": "debugger eval code",
-                "line": 1
-              }
             },
             "set": {
               "type": "undefined"
             }
           },
           baz: {
-            "configurable": true,
-            "enumerable": true,
             "get": {
               "type": "undefined"
             },
             "set": {
               "type": "object",
-              "actor": "server2.conn1.child1/obj116",
-              "class": "Function",
-              "extensible": true,
-              "frozen": false,
-              "sealed": false,
-              "name": "set x",
-              "displayName": "set x",
-              "location": {
-                "url": "debugger eval code",
-                "line": 1
-              }
             }
           }
         },

packages/devtools-reps/src/object-inspector/tests/utils/promises.js

@@ -14,29 +14,16 @@ describe("promises utils function", () => {
         enumerable: true,
         configurable: false,
         value: {
-          frozen: false,
-          ownPropertyLength: 0,
-          preview: {
-            kind: "Object",
-            ownProperties: {},
-            ownPropertiesLength: 0,
-            safeGetterValues: {}
-          },
           actor: "server2.conn2.child1/pausedobj36",
           promiseState: {
             state: "rejected",
             reason: {
               type: "undefined"
             },
-            creationTimestamp: 1486584316133.3994,
-            timeToSettle: 0.001713000237941742
           },
           class: "Promise",
           type: "object",
-          extensible: true,
-          sealed: false
         },
-        writable: true
       }
     };
 
@@ -47,32 +34,17 @@ describe("promises utils function", () => {
     const promise = {
       path: "root",
       contents: {
-        enumerable: true,
-        configurable: false,
         value: {
-          frozen: false,
-          ownPropertyLength: 0,
-          preview: {
-            kind: "Object",
-            ownProperties: {},
-            ownPropertiesLength: 0,
-            safeGetterValues: {}
-          },
           actor: "server2.conn2.child1/pausedobj36",
           promiseState: {
             state: "rejected",
             reason: {
               type: "3"
             },
-            creationTimestamp: 1486584316133.3994,
-            timeToSettle: 0.001713000237941742
           },
           class: "Promise",
           type: "object",
-          extensible: true,
-          sealed: false
         },
-        writable: true
       }
     };
 

packages/devtools-reps/src/object-inspector/utils.js

@@ -13,17 +13,19 @@ if (typeof window === "object") {
 }
 
 function getValue(item) {
-  let value;
-
   if (has(item, "contents.value")) {
-    value = get(item, "contents.value");
-  } else if (has(item, "contents.getterValue")) {
-    value = get(item, "contents.getterValue", undefined);
-  } else if (nodeHasAccessors(item)) {
-    value = item.contents;
+    return get(item, "contents.value");
+  }
+
+  if (has(item, "contents.getterValue")) {
+    return get(item, "contents.getterValue", undefined);
+  }
+
+  if (nodeHasAccessors(item)) {
+    return item.contents;
   }
 
-  return value;
+  return undefined;
 }
 
 function isBucket(item) {