Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Commit 67c1c8c

Browse files
author
Bruno Scopelliti
committed
Upgrade
1 parent 689961b commit 67c1c8c

File tree

3 files changed

+23
-9
lines changed

3 files changed

+23
-9
lines changed

packages/devtools-launchpad/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"babel-preset-react": "^6.24.1",
4444
"babel-register": "^6.18.0",
4545
"body-parser": "^1.15.2",
46-
"check-node-version": "^1.1.2",
46+
"check-node-version": "^3.2.0",
4747
"chrome-remote-interface": "0.17.0",
4848
"classnames": "^2.2.5",
4949
"co": "=4.6.0",

packages/devtools-launchpad/src/development-server.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,12 @@ function onRequest(err, result) {
133133
function startDevServer(devConfig, webpackConfig, rootDir) {
134134
setConfig(devConfig);
135135
root = rootDir;
136-
checkNode({ node: NODE_VERSION }, (_, opts) => {
137-
if (!opts.nodeSatisfied) {
138-
const version = opts.node.raw;
139-
console.log(`Sorry, Your version of node is ${version}.`);
136+
checkNode({ node: NODE_VERSION }, (_, result) => {
137+
if (!result.isSatisfied) {
138+
const currentVersion = result.versions.node.version
139+
? result.versions.node.version.version
140+
: "UNKNOWN";
141+
console.log(`Sorry, Your version of node is ${currentVersion}.`);
140142
console.log(`The minimum requirement is ${NODE_VERSION}`);
141143
process.exit();
142144
}

packages/devtools-launchpad/yarn.lock

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1229,7 +1229,7 @@ chalk@^1.0.0, chalk@^1.1.1, chalk@^1.1.3:
12291229
strip-ansi "^3.0.0"
12301230
supports-color "^2.0.0"
12311231

1232-
chalk@^2.4.1:
1232+
chalk@^2.3.0, chalk@^2.4.1:
12331233
version "2.4.1"
12341234
resolved "https://registry.yarnpkg.com/chalk/-/chalk-2.4.1.tgz#18c49ab16a037b6eb0152cc83e3471338215b66e"
12351235
dependencies:
@@ -1251,11 +1251,15 @@ charenc@~0.0.1:
12511251
version "0.0.2"
12521252
resolved "https://registry.yarnpkg.com/charenc/-/charenc-0.0.2.tgz#c0a1d2f3a7092e03774bfa83f14c0fc5790a8667"
12531253

1254-
check-node-version@^1.1.2:
1255-
version "1.1.2"
1256-
resolved "https://registry.yarnpkg.com/check-node-version/-/check-node-version-1.1.2.tgz#d48214ec629e3bf9f8f3ecee9feefeac723c864e"
1254+
check-node-version@^3.2.0:
1255+
version "3.2.0"
1256+
resolved "https://registry.yarnpkg.com/check-node-version/-/check-node-version-3.2.0.tgz#783a4292dbf76d6b8294b23abece33682b4a7cce"
12571257
dependencies:
1258+
chalk "^2.3.0"
1259+
map-values "^1.0.1"
12581260
minimist "^1.2.0"
1261+
object-filter "^1.0.2"
1262+
object.assign "^4.0.4"
12591263
run-parallel "^1.1.4"
12601264
semver "^5.0.3"
12611265

@@ -3942,6 +3946,10 @@ map-cache@^0.2.2:
39423946
version "0.2.2"
39433947
resolved "https://registry.yarnpkg.com/map-cache/-/map-cache-0.2.2.tgz#c32abd0bd6525d9b051645bb4f26ac5dc98a0dbf"
39443948

3949+
map-values@^1.0.1:
3950+
version "1.0.1"
3951+
resolved "https://registry.yarnpkg.com/map-values/-/map-values-1.0.1.tgz#768b8e79c009bf2b64fee806e22a7b1c4190c990"
3952+
39453953
map-visit@^1.0.0:
39463954
version "1.0.0"
39473955
resolved "https://registry.yarnpkg.com/map-visit/-/map-visit-1.0.0.tgz#ecdca8f13144e660f1b5bd41f12f3479d98dfb8f"
@@ -4382,6 +4390,10 @@ object-copy@^0.1.0:
43824390
define-property "^0.2.5"
43834391
kind-of "^3.0.3"
43844392

4393+
object-filter@^1.0.2:
4394+
version "1.0.2"
4395+
resolved "https://registry.yarnpkg.com/object-filter/-/object-filter-1.0.2.tgz#af0b797ffebeaf8a52c6637cedbe8816cfec1bc8"
4396+
43854397
object-keys@^1.0.11, object-keys@^1.0.8:
43864398
version "1.0.12"
43874399
resolved "https://registry.yarnpkg.com/object-keys/-/object-keys-1.0.12.tgz#09c53855377575310cca62f55bb334abff7b3ed2"

0 commit comments

Comments
 (0)