Clarify fullText retrieval and display

* revert check change in nodeHasEntries

Author: 2007heaven

packages/devtools-reps/src/object-inspector/component.js

@@ -307,9 +307,11 @@ class ObjectInspector extends Component {
         repProps.mode = MODE.TINY;
       }
 
-      repProps.member = {
-        open: nodeHasFullText(item) && expanded
-      };
+      if (nodeIsLongString(item)) {
+        repProps.member = {
+          open: nodeHasFullText(item) && expanded
+        };
+      }
 
       return {
         label,

packages/devtools-reps/src/object-inspector/utils/load-properties.js

@@ -73,7 +73,10 @@ function loadItemProperties(
   }
 
   if (shouldLoadFullText(item, loadedProperties)) {
-    promises.push(getFullText(getObjectClient(), getValue(item)));
+    promises.push(
+      getFullText(getObjectClient(), getValue(item))
+        .then(fullString => ({fullString}))
+    );
   }
 
   return Promise.all(promises).then(mergeResponses);
@@ -95,8 +98,8 @@ function mergeResponses(responses: Array<Object>) : Object {
       data.prototype = response.prototype;
     }
 
-    if (typeof response === "string") {
-      data.fullText = response;
+    if (response.fullText) {
+      data.fullText = response.response;
     }
   }
 

packages/devtools-reps/src/object-inspector/utils/node.js

@@ -249,12 +249,10 @@ function nodeHasEntries(
     return false;
   }
 
-  return [
-    "Map",
-    "Set",
-    "WeakMap",
-    "WeakSet"
-  ].includes(value.class);
+  return value.class === "Map"
+    || value.class === "Set"
+    || value.class === "WeakMap"
+    || value.class === "WeakSet";
 }
 
 function nodeHasAllEntriesInPreview(item : Node) : boolean {