Add better mocks in ObjectInspector tests.

Thanks to the warning added in the previous commit, some silent errors were made visible.
Providing better mocking functions fixes the issue.

Author: nchevobbe

packages/devtools-reps/src/object-inspector/tests/component/entries.js

@@ -22,10 +22,18 @@ function generateDefaults(overrides) {
   }, overrides);
 }
 
+function getEnumEntriesMock() {
+  return jest.fn(() => ({
+    iterator: {
+      slice: () => ({})
+    }
+  }));
+}
+
 describe("ObjectInspector - entries", () => {
   it("renders Object with entries as expected", async () => {
     const stub = gripMapRepStubs.get("testSymbolKeyedMap");
-    const enumEntries = jest.fn();
+    const enumEntries = getEnumEntriesMock();
 
     let oi = mount(ObjectInspector(generateDefaults({
       autoExpandDepth: 3,
@@ -54,7 +62,7 @@ describe("ObjectInspector - entries", () => {
 
   it("does not call enumEntries if entries are already loaded", () => {
     const stub = gripMapRepStubs.get("testMoreThanMaxEntries");
-    const enumEntries = jest.fn();
+    const enumEntries = getEnumEntriesMock();
 
     const wrapper = mount(ObjectInspector(generateDefaults({
       autoExpandDepth: 3,
@@ -79,7 +87,7 @@ describe("ObjectInspector - entries", () => {
 
   it("calls ObjectClient.enumEntries when an <entries> node is clicked", () => {
     const stub = gripMapRepStubs.get("testMoreThanMaxEntries");
-    const enumEntries = jest.fn();
+    const enumEntries = getEnumEntriesMock();
 
     const oi = mount(ObjectInspector(generateDefaults({
       autoExpandDepth: 1,

packages/devtools-reps/src/object-inspector/tests/component/properties.js

@@ -19,10 +19,18 @@ function generateDefaults(overrides) {
   }, overrides);
 }
 
+function getEnumPropertiesMock() {
+  return jest.fn(() => ({
+    iterator: {
+      slice: () => ({})
+    }
+  }));
+}
+
 describe("ObjectInspector - properties", () => {
   it("does not load properties if properties are already loaded", () => {
     const stub = gripRepStubs.get("testMaxProps");
-    const enumProperties = jest.fn();
+    const enumProperties = getEnumPropertiesMock();
 
     mount(ObjectInspector(generateDefaults({
       autoExpandDepth: 1,
@@ -43,7 +51,7 @@ describe("ObjectInspector - properties", () => {
 
   it("calls enumProperties when expandable leaf is clicked", () => {
     const stub = gripRepStubs.get("testMaxProps");
-    const enumProperties = jest.fn();
+    const enumProperties = getEnumPropertiesMock();
 
     const oi = mount(ObjectInspector(generateDefaults({
       roots: [{

packages/devtools-reps/src/object-inspector/tests/component/proxy.js

@@ -30,9 +30,17 @@ function generateDefaults(overrides) {
   }, overrides);
 }
 
+function getEnumPropertiesMock() {
+  return jest.fn(() => ({
+    iterator: {
+      slice: () => ({})
+    }
+  }));
+}
+
 describe("ObjectInspector - Proxy", () => {
   it("renders Proxy as expected", () => {
-    const enumProperties = jest.fn();
+    const enumProperties = getEnumPropertiesMock();
 
     const props = generateDefaults({
       createObjectClient: grip => ObjectClient(grip, {enumProperties}),
@@ -45,7 +53,7 @@ describe("ObjectInspector - Proxy", () => {
   });
 
   it("calls enumProperties when <target> and <handler> nodes are clicked", () => {
-    const enumProperties = jest.fn();
+    const enumProperties = getEnumPropertiesMock();
 
     const props = generateDefaults({
       createObjectClient: grip => ObjectClient(grip, {enumProperties}),