Do not linkify javascript: URLs

Author: nchevobbe

packages/devtools-reps/src/reps/rep-utils.js

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // Dependencies
-const validProtocols = /^(http|https|ftp|data|javascript|resource|chrome):/i;
+const validProtocols = /^(http|https|ftp|data|resource|chrome):/i;
 const tokenSplitRegex = /(\s|\'|\"|\\)+/;
 const ELLIPSIS = "\u2026";
 const dom = require("react-dom-factories");

packages/devtools-reps/src/reps/tests/string-with-url.js

@@ -452,4 +452,15 @@ describe("test String with URL", () => {
     link.simulate("click");
     expect(openLink).toBeCalledWith(url);
   });
+
+  it("does not render links for js URL", () => {
+    const url = "javascript:x=42";
+    const string = `${url} some other text`;
+
+    const openLink = jest.fn();
+    const element = renderRep(string, {openLink, useQuotes: false});
+    expect(element.text()).toEqual(string);
+    const link = element.find("a");
+    expect(link.exists()).toBe(false);
+  });
 });