Output the content-length value in the error message, when we know it

Author: julienw

src/routes/publish.ts

@@ -55,9 +55,9 @@ export function publishRoutes() {
     if (expectedLength !== undefined && expectedLength > MAX_BODY_LENGTH) {
       log.verbose(
         'length-header-check',
-        'The length specified in the header Content-Length is too big.'
+        `The length specified in the header Content-Length (${expectedLength}) is too big.`
       );
-      throw new PayloadTooLargeError(MAX_BODY_LENGTH);
+      throw new PayloadTooLargeError(MAX_BODY_LENGTH, expectedLength);
     }
 
     const profileToken = await generateTokenForProfile();

src/utils/errors.ts

@@ -27,9 +27,10 @@ export class PayloadTooLargeError extends Error {
   status = 413;
   expose = true;
 
-  constructor(maxPayloadSize: number) {
-    super(
-      `The length is bigger than the configured maximum ${maxPayloadSize}.`
-    );
+  constructor(maxPayloadSize: number, receivedPayloadSize?: number) {
+    const message = receivedPayloadSize
+      ? `The received length ${receivedPayloadSize} is bigger than the configured maximum ${maxPayloadSize}.`
+      : `The length is bigger than the configured maximum ${maxPayloadSize}.`;
+    super(message);
   }
 }

test/api/publish.test.ts

@@ -127,7 +127,10 @@ describe('publishing endpoints', () => {
     const req = getPreconfiguredRequest();
     await req
       .set('Content-Length', String(1024 * 1024 * 1024))
-      .expect(413, /The length is bigger than the configured maximum/);
+      .expect(
+        413,
+        /The received length \d+ is bigger than the configured maximum/
+      );
     expect(process.stdout.write).toHaveBeenCalledWith(
       expect.stringContaining('server_error')
     );