Skip to content

Commit bd112ac

Browse files
authored
Update debian to bookworm (#458)
2 parents fc501e5 + 11051de commit bd112ac

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

Dockerfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
# instead of the default. See docs-developer/docker.md for more information.
1212

1313
# Setup a container and build the project in it
14-
# We set up a node 18 running in latest Debian stable called bullseye, in the
14+
# We set up a node 18 running in latest Debian stable called bookworm, in the
1515
# "slim" flavor because we don't need the big version.
16-
FROM node:18-bullseye-slim AS builder
16+
# NOTE: if you update the image here, don't forget to update it below as well.
17+
FROM node:18-bookworm-slim AS builder
1718

1819
# Create the user we'll run the build commands with. Its home is configured to
1920
# be the directory /app. It helps avoiding warnings when running tests and
@@ -86,7 +87,7 @@ RUN du -khs node_modules
8687
RUN ls -la
8788

8889
# ----- And now, let's build the runtime container -----
89-
FROM node:18-bullseye-slim
90+
FROM node:18-bookworm-slim
9091
ENV NODE_ENV="production"
9192
ENV PORT=8000
9293

docs-developer/docker.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ Especially the environment variable `JWT_SECRET` needs to be set.
3535

3636
If the variable `GCS_AUTHENTICATION_PATH` is set the pointed file will be
3737
mounted to the docker instance as well, so that Google Storage authentication
38-
works.
38+
works. Make sure to change its group to "10001" so that the docker image can
39+
access it.
3940

4041
The app should listen on port 8000. The container is named `profiler-server`.
4142

loadtest/Dockerfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
# runtime with the env variable API_ENDPOINT.
1212

1313
# Setup a container and download the project in it
14-
# We set up a python 3 running in latest Debian stable called bullseye, in the
14+
# We set up a python 3 running in latest Debian stable called bookworm, in the
1515
# "slim" flavor because we don't need the big version.
16-
FROM python:3-slim-bullseye
16+
FROM python:3-slim-bookworm
1717

1818
# Create the user we'll run the build commands with. Its home is configured to
1919
# be the directory /app. It helps avoiding warnings when running tests and
@@ -28,8 +28,9 @@ RUN mkdir /app \
2828

2929
# Install various needed packages:
3030
# - git, as we'll need it to pull molotov
31+
# - build tools, as this is needed for some Python packages
3132
RUN apt-get update \
32-
&& apt-get install -y --no-install-recommends git \
33+
&& apt-get install -y --no-install-recommends git build-essential \
3334
# and clean the downloaded lists so that they don't increase the layer size.
3435
&& rm -rf /var/lib/apt/lists/*
3536

0 commit comments

Comments
 (0)